-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user_config.properties #364
Merged
OneSizeFitsQuorum
merged 7 commits into
thulab:master
from
liyuheng55555:custom_properties
Aug 18, 2023
Merged
Add user_config.properties #364
OneSizeFitsQuorum
merged 7 commits into
thulab:master
from
liyuheng55555:custom_properties
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # configuration/benchmark.sh
SpriCoder
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
OneSizeFitsQuorum
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
liyuheng55555
added a commit
to liyuheng55555/iot-benchmark
that referenced
this pull request
Sep 5, 2023
This reverts commit 5a61353.
OneSizeFitsQuorum
pushed a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are too many parameters in
config.properties
, but when debugging, we often focus on and modify only a few of them, which is cumbersome to keep flipping through.The newly added
user_config.properties
allows you to configure only the parameters you care about.Its priority is higher than config.properties, meaning it overrides the parameters in config.properties.