Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format transaction amount #744

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Format transaction amount #744

wants to merge 6 commits into from
+23 −9

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Nov 11, 2024 •
edited
Loading

Changes

  • Create getTransactionAmount fn to format any amount

image

image

image

Related issue: #698

AhmedHanafy725
AhmedHanafy725 requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be done at all places, and I would like to have units too like KTFT, MTFT, and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @AhmedHanafy725