Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(deploymentList/Caprover): enhance deleting caprover deployment #3675

Open
wants to merge 2 commits into
base: development_2.7
Choose a base branch
from
Open

Refactor(deploymentList/Caprover): enhance deleting caprover deployment #3675

wants to merge 2 commits into from
+4 −7

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Nov 24, 2024 •
edited
Loading

Description

Refactor deleting Caprover deployment:
the old flow was pushing all workers to an array and delete them instance by instance

now we are using machines.delete to delete the deployment

Changes

  • add isCaprover prop to manage delete caprover deployment
  • remove the old logic

Related Issues

Tested Scenarios

  • cereate caprover deployment worker and leader and delete it from deployemnt list, check the contract list after few seconds to avoid delay conflect, all deployement contracts should be deleted
  • deploy multiple machines uisng gridClient script then delete one of them, should keep the other one ( this test to make sure no side effect because of the changes)

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@ramezsaeed ramezsaeed mentioned this pull request Nov 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramezsaeed ramezsaeed ramezsaeed approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0oM4R @ramezsaeed