Fix GPU card in node details #3424

zaelgohary · 2024-09-19T08:36:29Z

Changes

Update GridNode type in proxy
Replace cards arr with GPU arr from grid proxy
Apply changes in Playground
Remove unused log
Removed repeated type & unnecessary code

Related Issues

Tested Scenarios

List GPU cards of a down node 250
Check node details of an up node
Check node details of a down node w no gpu

Checklist

…ly changes in Playground, remove unused log

packages/gridproxy_client/src/modules/gateways.ts

maayarosama · 2024-09-19T12:38:24Z

Couldn't test because there's no standby nodes with gpu cards on dev or main

zaelgohary · 2024-09-19T17:25:08Z

Couldn't test because there's no standby nodes with gpu cards on dev or main

You can test with an offline node.

amiraabouhadid

Is this loadGpu still necessary then?

amiraabouhadid

Did not work for an offline node :(

Am I missing something? Gpu card does not load even after pressing try again.

zaelgohary · 2024-09-24T07:26:33Z

Did not work for an offline node :(

I made changes in Grid Proxy Client. Did you build before running the playground?

amiraabouhadid · 2024-09-24T14:02:42Z

Did not work for an offline node :(

I made changes in Grid Proxy Client. Did you build before running the playground?

my bad, was testing it on staging instead of locally, works

why is this loadGpu still necessary though?

…onfig type w NodesExtractOptions from grid proxy

zaelgohary · 2024-09-26T08:19:42Z

@amiraabouhadid I did some refactoring. You can test now.

…-sdk-ts into development_fix_gpu_card

amiraabouhadid

I get this error when I press the x beside the selected GPU

[Uncaught Error]
- Message: Cannot read properties of undefined (reading 'vendor')
- Stack: TypeError: Cannot read properties of undefined (reading 'vendor')
    at getNodeTwinDetailsCard (http://localhost:5173/src/components/node_details_cards/gpu_details_card.vue:43:37)
    at http://localhost:5173/src/components/node_details_cards/gpu_details_card.vue:23:25
    at callWithErrorHandling (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1584:18)
    at callWithAsyncErrorHandling (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1592:17)
    at job (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:3181:9)
    at callWithErrorHandling (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1584:32)
    at flushJobs (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1782:9)
- Constructor: TypeError
(anonymous) @ @sentry_vue.js?v=62295903:851
(anonymous) @ logger-interceptor.js?v=62295903:60
app.config.errorHandler @ main.ts:18
app.config.errorHandler @ @sentry_vue.js?v=62295903:22512
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
handleError @ chunk-S4KY57GZ.js?v=62295903:1625
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1586
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
job @ chunk-S4KY57GZ.js?v=62295903:3181
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
flushJobs @ chunk-S4KY57GZ.js?v=62295903:1782
Promise.then
queueFlush @ chunk-S4KY57GZ.js?v=62295903:1695
queueJob @ chunk-S4KY57GZ.js?v=62295903:1689
scheduler @ chunk-S4KY57GZ.js?v=62295903:3203
triggerEffect @ chunk-S4KY57GZ.js?v=62295903:633
triggerEffects @ chunk-S4KY57GZ.js?v=62295903:623
triggerRefValue @ chunk-S4KY57GZ.js?v=62295903:1230
set value @ chunk-S4KY57GZ.js?v=62295903:1274
set @ chunk-S4KY57GZ.js?v=62295903:1292
_createVNode.onUpdate:modelValue._cache.<computed>._cache.<computed> @ gpu_details_card.vue:27
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
onModelUpdate @ vuetify_components.js?v=62295903:9343
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
(anonymous) @ vuetify_components.js?v=62295903:8554
Promise.then
nextTick @ chunk-S4KY57GZ.js?v=62295903:1667
onClear @ vuetify_components.js?v=62295903:8553
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
invoker @ chunk-S4KY57GZ.js?v=62295903:9414
sentryWrapped @ @sentry_vue.js?v=62295903:7589
Show 36 more frames
Show lessUnderstand this error
gpu_details_card.vue:27 [Vue warn]: Error in watcher callback: "TypeError: Cannot read properties of undefined (reading 'vendor')"

found in

---> <GPUDetailsCard> at /home/amira/tfgrid-sdk-ts/packages/playground/src/components/node_details_cards/gpu_details_card.vue... (6 recursive calls)
       <VDialog>
         <NodeDetails> at /home/amira/tfgrid-sdk-ts/packages/playground/src/components/node_details.vue... (6 recursive calls)
           <DeploymentListManager> at /home/amira/tfgrid-sdk-ts/packages/playground/src/components/deployment_list_manager.vue
             <VMain>... (2 recursive calls)
               <App> at /home/amira/tfgrid-sdk-ts/packages/playground/src/App.vue
                 <AsyncComponentWrapper>
(anonymous) @ @sentry_vue.js?v=62295903:22521
consoleSandbox @ @sentry_vue.js?v=62295903:418
app.config.errorHandler @ @sentry_vue.js?v=62295903:22520
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
handleError @ chunk-S4KY57GZ.js?v=62295903:1625
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1586
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
job @ chunk-S4KY57GZ.js?v=62295903:3181
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
flushJobs @ chunk-S4KY57GZ.js?v=62295903:1782
Promise.then
queueFlush @ chunk-S4KY57GZ.js?v=62295903:1695
queueJob @ chunk-S4KY57GZ.js?v=62295903:1689
scheduler @ chunk-S4KY57GZ.js?v=62295903:3203
triggerEffect @ chunk-S4KY57GZ.js?v=62295903:633
triggerEffects @ chunk-S4KY57GZ.js?v=62295903:623
triggerRefValue @ chunk-S4KY57GZ.js?v=62295903:1230
set value @ chunk-S4KY57GZ.js?v=62295903:1274
set @ chunk-S4KY57GZ.js?v=62295903:1292
_createVNode.onUpdate:modelValue._cache.<computed>._cache.<computed> @ gpu_details_card.vue:27
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
onModelUpdate @ vuetify_components.js?v=62295903:9343
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
(anonymous) @ vuetify_components.js?v=62295903:8554
Promise.then
nextTick @ chunk-S4KY57GZ.js?v=62295903:1667
onClear @ vuetify_components.js?v=62295903:8553
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
invoker @ chunk-S4KY57GZ.js?v=62295903:9414
sentryWrapped @ @sentry_vue.js?v=62295903:7589
Show 36 more frames
Show lessUnderstand this error
main.ts:18 [Uncaught Error]
- Message: Cannot read properties of undefined (reading 'contract')
- Stack: TypeError: Cannot read properties of undefined (reading 'contract')
    at http://localhost:5173/src/components/node_details_cards/gpu_details_card.vue:103:46
    at Proxy.renderFnWithContext (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:2194:13)
    at Proxy.<anonymous> (http://localhost:5173/node_modules/.vite/deps/vuetify_components.js?v=62295903:17124:55)
    at renderComponentRoot (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:2243:17)
    at ReactiveEffect.componentUpdateFn [as fn] (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:7179:26)
    at ReactiveEffect.run (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:442:19)
    at instance.update (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:7229:52)
    at callWithErrorHandling (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1584:32)
    at flushJobs (http://localhost:5173/node_modules/.vite/deps/chunk-S4KY57GZ.js?v=62295903:1782:9)
- Constructor: TypeError
(anonymous) @ @sentry_vue.js?v=62295903:851
(anonymous) @ logger-interceptor.js?v=62295903:60
app.config.errorHandler @ main.ts:18
app.config.errorHandler @ @sentry_vue.js?v=62295903:22512
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
handleError @ chunk-S4KY57GZ.js?v=62295903:1625
renderComponentRoot @ chunk-S4KY57GZ.js?v=62295903:2280
componentUpdateFn @ chunk-S4KY57GZ.js?v=62295903:7179
run @ chunk-S4KY57GZ.js?v=62295903:442
instance.update @ chunk-S4KY57GZ.js?v=62295903:7229
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
flushJobs @ chunk-S4KY57GZ.js?v=62295903:1782
Promise.then
queueFlush @ chunk-S4KY57GZ.js?v=62295903:1695
queueJob @ chunk-S4KY57GZ.js?v=62295903:1689
scheduler @ chunk-S4KY57GZ.js?v=62295903:3203
triggerEffect @ chunk-S4KY57GZ.js?v=62295903:633
triggerEffects @ chunk-S4KY57GZ.js?v=62295903:623
triggerRefValue @ chunk-S4KY57GZ.js?v=62295903:1230
set value @ chunk-S4KY57GZ.js?v=62295903:1274
set @ chunk-S4KY57GZ.js?v=62295903:1292
_createVNode.onUpdate:modelValue._cache.<computed>._cache.<computed> @ gpu_details_card.vue:27
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
onModelUpdate @ vuetify_components.js?v=62295903:9343
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
emit @ chunk-S4KY57GZ.js?v=62295903:2093
set @ chunk-TJM6J5C4.js?v=62295903:124
set value @ chunk-S4KY57GZ.js?v=62295903:1407
(anonymous) @ vuetify_components.js?v=62295903:8554
Promise.then
nextTick @ chunk-S4KY57GZ.js?v=62295903:1667
onClear @ vuetify_components.js?v=62295903:8553
callWithErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1584
callWithAsyncErrorHandling @ chunk-S4KY57GZ.js?v=62295903:1592
invoker @ chunk-S4KY57GZ.js?v=62295903:9414
sentryWrapped @ @sentry_vue.js?v=62295903:7589
Show 37 more frames
Show lessUnderstand this error
gpu_details_card.vue:27 [Vue warn]: Error in render function: "TypeError: Cannot read properties of undefined (reading 'contract')"

found in

---> <VCol>... (11 recursive calls)
       <VDialog>
         <NodeDetails> at /home/amira/tfgrid-sdk-ts/packages/playground/src/components/node_details.vue... (6 recursive calls)
           <DeploymentListManager> at /home/amira/tfgrid-sdk-ts/packages/playground/src/components/deployment_list_manager.vue
             <VMain>... (2 recursive calls)
               <App> at /home/amira/tfgrid-sdk-ts/packages/playground/src/App.vue
                 <AsyncComponentWrapper>
```

zaelgohary · 2024-09-26T11:28:34Z

I get this error when I press the x beside the selected GPU

Did you run make build in root?

zaelgohary · 2024-09-26T16:53:35Z

@amiraabouhadid issue was found on staging.

It should be fixed now.

Update GridNode type in proxy, remove unnecessary cards property, app…

5f2917a

…ly changes in Playground, remove unused log

zaelgohary requested review from AhmedHanafy725, maayarosama, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar, 0oM4R and samaradel as code owners September 19, 2024 08:36

Remove unused import

8d25b9a

maayarosama reviewed Sep 19, 2024

View reviewed changes

packages/gridproxy_client/src/modules/gateways.ts Show resolved Hide resolved

zaelgohary requested a review from maayarosama September 19, 2024 17:27

maayarosama approved these changes Sep 22, 2024

View reviewed changes

amiraabouhadid reviewed Sep 23, 2024

View reviewed changes

amiraabouhadid requested changes Sep 23, 2024

View reviewed changes

zaelgohary requested a review from amiraabouhadid September 24, 2024 10:04

Remove loadgpu & refactor gpu details card, replace GridProxyRequestC…

6539c40

…onfig type w NodesExtractOptions from grid proxy

zaelgohary added 3 commits September 26, 2024 11:24

Remove unused async

ab63dbc

Remove unnessecary variable & condition

a0f948b

Merge branch 'development' of https://github.com/threefoldtech/tfgrid…

287d045

…-sdk-ts into development_fix_gpu_card

amiraabouhadid reviewed Sep 26, 2024

View reviewed changes

zaelgohary requested a review from amiraabouhadid September 26, 2024 11:30

Make chips not clearable

e047182

amiraabouhadid approved these changes Sep 29, 2024

View reviewed changes

zaelgohary merged commit b760b10 into development Sep 29, 2024
10 checks passed

zaelgohary deleted the development_fix_gpu_card branch September 29, 2024 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GPU card in node details #3424

Fix GPU card in node details #3424

zaelgohary commented Sep 19, 2024 •

edited

Loading

maayarosama commented Sep 19, 2024

zaelgohary commented Sep 19, 2024

amiraabouhadid left a comment

amiraabouhadid left a comment •

edited

Loading

zaelgohary commented Sep 24, 2024

amiraabouhadid commented Sep 24, 2024 •

edited

Loading

zaelgohary commented Sep 26, 2024

amiraabouhadid left a comment •

edited

Loading

zaelgohary commented Sep 26, 2024

zaelgohary commented Sep 26, 2024

Fix GPU card in node details #3424

Fix GPU card in node details #3424

Conversation

zaelgohary commented Sep 19, 2024 • edited Loading

Changes

Related Issues

Tested Scenarios

Checklist

maayarosama commented Sep 19, 2024

zaelgohary commented Sep 19, 2024

amiraabouhadid left a comment

Choose a reason for hiding this comment

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

zaelgohary commented Sep 24, 2024

amiraabouhadid commented Sep 24, 2024 • edited Loading

zaelgohary commented Sep 26, 2024

amiraabouhadid left a comment • edited Loading

Choose a reason for hiding this comment

zaelgohary commented Sep 26, 2024

zaelgohary commented Sep 26, 2024

zaelgohary commented Sep 19, 2024 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading

amiraabouhadid commented Sep 24, 2024 •

edited

Loading

amiraabouhadid left a comment •

edited

Loading