check for client before calling clientoptions #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiraabouhadid
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
zaelgohary
reviewed
Sep 17, 2024
maayarosama
previously requested changes
Sep 18, 2024
amiraabouhadid
force-pushed
the
dev_fix_clientoptions_err
branch
from
b844454
to
d333d30
Compare
|
@zaelgohary your suggestion fails to update the timeout on the client. I was able to deploy even though deploymentTimeout is set to 3 seconds in localstorage. |
zaelgohary
approved these changes
Sep 23, 2024
maayarosama
approved these changes
Sep 24, 2024
samaradel
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
#3411
Tested Scenarios