Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: switch from auto generated GITHUB_TOKEN to PAT #863

Merged
merged 1 commit into from
Sep 12, 2023
Merged

ci: switch from auto generated GITHUB_TOKEN to PAT #863

merged 1 commit into from
Sep 12, 2023

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Sep 12, 2023 •
edited
Loading

Description

  • What does this PR do?
    Switching from auto generated GITHUB_TOKEN to PAT in release workflow

  • Why are these changes needed?
    Triggering a workflow from a workflow that uses automatic GITHUB_TOKEN won't work.
    This why The release created by by create_release workflow won't trigger workflow publich-activation-service-image. for more info about this see here

  • How were these changes implemented and what do they affect?
    Next time create_release runs it should trigger properly publich-activation-service-image workflow.

Checklist:

@renauter renauter merged commit ea15ebb into development Sep 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renauter renauter renauter approved these changes

@brandonpille brandonpille Awaiting requested review from brandonpille

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sameh-farouk @renauter