Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ASCII for sharp signs #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeandeaual
Copy link

@jeandeaual jeandeaual commented Jan 24, 2021

Thanks for writing this awesome library!

I noticed that the tablature format used by default (tsugaru-signs) uses the ♯ (MUSIC SHARP SIGN) character for sharps, which makes sense, but doesn't align well with other numbers in a chord:

sample-hash-before

This PR adds tsugaru-signs-ascii as an option, which uses # instead, for a more consistent look:

sample-hash

The second commit makes \tsugaruNotation take the tablature as an argument (unfortunately mandatory since music functions need at least one mandatory argument to have optional arguments), but if that's unnecessary I can remove it.

Here is the code used for testing:

\version "2.20.0"

\include "shamisen.ly"

#(set-global-staff-size 32)

\header {
  tagline = ##f
}

\paper{
  page-breaking = #ly:one-line-auto-height-breaking
  #(define fonts
    (set-global-fonts
     #:roman "IPAexGothic"
     #:factor (/ staff-height pt 20)
    ))
}

\score {
  \new TabStaff \with { stringTunings = #niagariTuning } {
    \shamisenNotation #tsugaru-signs-ascii
    \time 2/4

    <c b c'>2 |

    \bar "|."
  }
}

@jeandeaual jeandeaual changed the title Allow using ASCII for sharp signsdditional notation Allow using ASCII for sharp signs Jan 24, 2021
@jeandeaual
Copy link
Author

I realized the PDF I created didn't use IPAexGothic for the tab notation for some reason. With IPAexGothic, the output looks way better with the default tablature format, so this PR might not be very useful…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant