Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing this awesome library!
I noticed that the tablature format used by default (
tsugaru-signs
) uses the ♯ (MUSIC SHARP SIGN) character for sharps, which makes sense, but doesn't align well with other numbers in a chord:This PR adds
tsugaru-signs-ascii
as an option, which uses # instead, for a more consistent look:The second commit makes
\tsugaruNotation
take the tablature as an argument (unfortunately mandatory since music functions need at least one mandatory argument to have optional arguments), but if that's unnecessary I can remove it.Here is the code used for testing: