Fixed cross-products of bindings

threatgrid · Aug 18, 2021 · 3ccaa09 · 3ccaa09
1 parent 28549f8
commit 3ccaa09
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/asami/query.cljc b/src/asami/query.cljc
@@ -406,7 +406,7 @@
       (throw (ex-info "Outer product between bindings should have distinct names" {:duplicate-names n})))
     (with-meta
       (for [row-l leftb row-r rightb]
-        (concat row-l row-r))
+        (vec (concat row-l row-r)))
       {:cols (into namesl namesr)})))
 
 (s/defn symb?

diff --git a/test/asami/query_internals_test.cljc b/test/asami/query_internals_test.cljc
@@ -141,6 +141,7 @@
       (is (= [[5]] bds))
       (is (= '[?a] (:cols (meta bds))))
       (is (= [[5 6]] bds2))
+      (is (vector? (first bds2)))
       (is (= '[?a ?b] (:cols (meta bds2))))
       (is (= [[5]] bds3))
       (is (= '[?a] (:cols (meta bds3))))))