Skip to content

Commit

Permalink
Reverts dual-publishing images to Docker Hub for ease of maintenance.
Browse files Browse the repository at this point in the history
These images were apparently never used.
-----

Revert "Clarify availability of images on Docker Hub as well as GHCR"

This reverts commit 2bd988b.

Revert "Dual-push images to Docker Hub and GHCR"

This reverts commit 53a0b03

Revert "Dual-push images to Docker Hub and GHCR"

This reverts commit a227874

Revert "Dual-push images to Docker Hub and GHCR"

This reverts commit a9975a9
  • Loading branch information
chadlwilson committed Nov 27, 2023
1 parent 1ba2edc commit 7eaa7d0
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 23 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,18 +63,8 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- if: ${{ endsWith(github.ref, '/master') || startsWith(github.ref, 'refs/tags/') }}
name: Login to Docker Hub Container Registry
uses: docker/login-action@v3
with:
registry: docker.io
username: ${{ vars.DOCKER_HUB_ID }}
password: ${{ secrets.DOCKER_HUB_TOKEN }}

- if: ${{ endsWith(github.ref, '/master') || startsWith(github.ref, 'refs/tags/') }}
name: Gradle Official Docker Build & Push
uses: gradle/gradle-build-action@v2
env:
JAVA_HOME: ${{ env.JAVA_HOME }}
with:
arguments: jibGitHubContainerRegistry jibDockerHub -x check
arguments: jibGitHubContainerRegistry -x check
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,5 +143,5 @@ Current release process looks like
# Patch version (e.g 0.6.0 -> 0.6.1)
./gradlew -Preckon.stage=final -Preckon.scope=patch reckonTagPush
```
2. The tag push will trigger a build on [GitHub Actions](https://github.com/ThoughtWorks-SEA/recce/actions) and push to both GHCR and Docker Hub.
2. The tag push will trigger a build on [GitHub Actions](https://github.com/ThoughtWorks-SEA/recce/actions) and push to GHCR.
3. Create a new release on Github via https://github.com/ThoughtWorks-SEA/recce/releases linked to the tag
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ You can read more about the ideas behind Recce at [DESIGN.md](docs/DESIGN.md) or

# Getting Started

Recce is currently published and available as a container image [via GHCR](https://github.com/ThoughtWorks-SEA/recce/pkgs/container/recce-server) or [Docker Hub](https://hub.docker.com/r/recceteam/recce-server), built for both AMD64 and ARM64.
Recce is currently [published and available as a container image via GHCR](https://github.com/ThoughtWorks-SEA/recce/pkgs/container/recce-server).

However, it also
* requires its own Postgres database
Expand Down
10 changes: 0 additions & 10 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -308,16 +308,6 @@ tasks.register<com.google.cloud.tools.jib.gradle.BuildImageTask>("jibGitHubConta
}
}

// Jib task pushes an image. Only do so after running all checks
tasks.register<com.google.cloud.tools.jib.gradle.BuildImageTask>("jibDockerHub") {
dependsOn(checkJibDependencies)
dependsOn(tasks.check)
setJibExtension(project.extensions.getByName("jib") as com.google.cloud.tools.jib.gradle.JibExtension)
doFirst {
jib?.to?.image = "docker.io/recceteam/$containerRepoName"
}
}

// use different naming when building locally, to avoid confusion
tasks.jibDockerBuild.configure {
dependsOn(checkJibDependencies)
Expand Down

0 comments on commit 7eaa7d0

Please sign in to comment.