[Refactor][Xiaomeng] extract pipeline.ts.

thoughtworks · Mar 29, 2021 · b760d5a · b760d5a
1 parent e635b70
commit b760d5a
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/frontend/src/clients/pipelineApis.ts b/frontend/src/clients/pipelineApis.ts
@@ -1,4 +1,5 @@
 import { createRequest } from "./createRequest";
+import { PipelineTool } from "../models/pipeline";
 
 export const createPipelineUsingPost = createRequest<{
 	projectId: string;
@@ -75,8 +76,3 @@ export type Pipeline = JenkinsPipeline | BambooPipeline;
 export type PipelineVerification =
 	| Omit<JenkinsPipeline, "id" | "name">
 	| Omit<BambooPipeline, "id" | "name">;
-
-export enum PipelineTool {
-	BAMBOO = "BAMBOO",
-	JENKINS = "JENKINS",
-}
diff --git a/frontend/src/components/PipelineSetup/PipelineSetup.tsx b/frontend/src/components/PipelineSetup/PipelineSetup.tsx
@@ -2,14 +2,14 @@ import {
 	BambooPipeline,
 	JenkinsPipeline,
 	Pipeline,
-	PipelineTool,
 	verifyPipelineUsingPost,
 } from "../../clients/pipelineApis";
 import React, { FC, useState } from "react";
 import { Alert, Button, Col, Divider, Form, Input, Row, Select, Typography } from "antd";
 import { css } from "@emotion/react";
 import { PIPELINE_CONFIG, PIPELINE_TYPE_NOTE } from "../../utils/pipelineConfig/pipelineConfig";
 import { VerifyStatus } from "../../models/common";
+import { PipelineTool } from "../../models/pipeline";
 
 const { Option } = Select;
 const { Text } = Typography;

diff --git a/frontend/src/constants/tooltips.ts b/frontend/src/constants/tooltips.ts
@@ -1,4 +1,4 @@
-import { PipelineTool } from "../clients/pipelineApis";
+import { PipelineTool } from "../models/pipeline";
 
 export const TOOLTIP_MAPPING = {
 	[PipelineTool.JENKINS]: {

diff --git a/frontend/src/models/pipeline.ts b/frontend/src/models/pipeline.ts
@@ -0,0 +1,4 @@
+export enum PipelineTool {
+	BAMBOO = "BAMBOO",
+	JENKINS = "JENKINS",
+}
diff --git a/frontend/src/models/project.ts b/frontend/src/models/project.ts
diff --git a/frontend/src/utils/pipelineConfig/pipelineConfig.tsx b/frontend/src/utils/pipelineConfig/pipelineConfig.tsx
@@ -1,7 +1,7 @@
 import React from "react";
-import { PipelineTool } from "../../clients/pipelineApis";
 import { JENKINS_PIPELINE_CONFIG } from "./jenkinsConfig";
 import { BAMBOO_PIPELINE_CONFIG } from "./bambooConfig";
+import { PipelineTool } from "../../models/pipeline";
 
 export const PIPELINE_CONFIG = {
 	[PipelineTool.JENKINS]: JENKINS_PIPELINE_CONFIG,