Add gRPC keepalive parameters #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping that this might mitigate an issue that seems to have appeared recently where Flair ends up with an apparently dead connection to the execution server, but never realises. Because
ExecuteRPCs have either no timeout or a very long one (because sadly you cannot set a timeout to the first RPC response on a stream), I don't think it figures out that it's wrong. This should hopefully make gRPC check it and (after a while) recycle the connection.I haven't set
PermitWithoutStreamso this should only generate keepalive traffic while it's actively being used.