Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BatchRead that returns the wrong number of blobs. #304

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

fische
Copy link
Contributor

@fische fische commented Apr 22, 2024

Since #303 has been merged, we're seeing errors like:

rpc error: code = InvalidArgument desc = Failed to download input root: rpc error: code = InvalidArgument desc = Unexpected response, requested 4 blobs, got 2

I believe this is just an issue in BatchRead that uses the index of the results to know their hashes (using the input keys).

@fische fische requested a review from Hamishpk April 22, 2024 15:36
@fische fische self-assigned this Apr 22, 2024
@fische fische merged commit d0e0f85 into thought-machine:master Apr 24, 2024
5 checks passed
@fische fische deleted the fix-batch branch April 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants