Start receiving from queue only once we got all inflight executions. #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamishpk
reviewed
Nov 10, 2023
Hamishpk
approved these changes
Nov 10, 2023
peterebden
approved these changes
Nov 10, 2023
Hamishpk
pushed a commit
to Hamishpk/please-servers
that referenced
this pull request
Mar 7, 2024
…hought-machine#269) * Receive from queue after getting list of jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a potential data race when we initialise the internal job cache. We used to start receiving from the queue first and then fetch the list of inflight executions to fill the internal job cache. The first uses a mutex to write to the cache but not the second. There are 2 solutions, either we keep the same order of doing things and we make sure to lock the mutex when filling the cache with inflight executions, or we just start receiving after initialising the cache. The latter seems safer to me, which is why I went for that solution.