Allow aicoe-ci to do only tox and precommit checks #145
Conversation
harshad16
requested review from
frenzymadness,
fridex and
goern
as code owners
sesheta
added
the
size/L
There was a problem hiding this comment.
nice! 💯 changes look good to me 👍
/assign @frenzymadness
PTAL
Signed-off-by: Harshad Reddy Nalla <[email protected]>
|
I'm not sure I am the right person to review all these changes and CI configs but overall they look good to me. |
Let's keep the Travis CI together with AICoE CI. Travis CI has configured support matrix we need. I'm personally fine with changes, are you OK with merging this? It will serve as an addition, not a replacement for any functionality present in the repo. |
|
I'm okay with these changes. More testing is always better. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Related Issues and Dependencies
Fixes: #143
Related-to: #101
This introduces a breaking change
This Pull Request implements
Allow aicoe-ci to do only tox and precommit checks
Signed-off-by: Harshad Reddy Nalla [email protected]
Description
This pull request has no code changes, just linting changes present.
As thoth-station component has moved from simple coala check to pre-commit check, in which multiple hooks can be run like flake, pep8, black, etc.
this pull-request would also stop the unnecessary, aicoe-ci/build-check and pytest-check on pull -request as it is not needed for micropipenv.
we have enabled tox -check, for the component, as we want to get the aicoe-ci to do better work in testing environments.
and also enable pre-commit check, which collaborators can run on their local system, by the following command:
pre-commit run --all-files