Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI clean up #101

Closed
frenzymadness opened this issue Jul 10, 2020 · 11 comments
Closed

CI clean up #101

frenzymadness opened this issue Jul 10, 2020 · 11 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@frenzymadness
Copy link
Collaborator

Could we please decide which parts of micropipenv's CI to remove or fix? I mean, It's kinda misleading to contributors when a PR is merged even when a big portion of tests is red or unfinished.

  • Thoth: Advise (Developer Preview) - does not work because we removed its config file
  • thoth-ci/* - fail on condition-check-deploy-comment-check and are not able to run tox/pytest tests.
  • tide - what this is supposed to do?

I'd say that the codebase is tested on Travis but others might also implement some important checks and if they do, we should fix them.

@goern
Copy link
Member

goern commented Jul 10, 2020

Thoth: Advise (Developer Preview) is a GitHub application that is generally/for all repos enabled in this org, the same for Prow/Tide. I can have a look at disabling both for this repo only.

aicoe-ci (or thoth-ci) should be able to run tox/pytest @harshad16

@goern
Copy link
Member

goern commented Jul 10, 2020

/assign goern
/assign harshad16

@fridex
Copy link
Collaborator

fridex commented Jul 17, 2020

Thoth: Advise (Developer Preview) is a GitHub application that is generally/for all repos enabled in this org, the same for Prow/Tide. I can have a look at disabling both for this repo only.

I've quickly checked the github settings. There is no configuration option to disable the github app for just one repo in the org. Do we want to maintain a list of enabled repos, are we fine for these checks to fail for this repo, or is there a "no-op" action to be configured somehow on Thoth side?
Screenshot_2020-07-17_13-02-09

@frenzymadness
Copy link
Collaborator Author

I am okay having them here because I know that only jobs I have to check are Travis and Coala but the motivation for this issue is how it looks to a new contributor.

@goern
Copy link
Member

goern commented Jul 22, 2020

BTW, why have we removed .thoth.yaml ?

@fridex
Copy link
Collaborator

fridex commented Jul 23, 2020

BTW, why have we removed .thoth.yaml ?

Pipfile/Pipfile.lock is not used in this repo, requirements are managed by tox:

micropipenv/tox.ini

Lines 7 to 16 in 0e6e0fe

deps =
flexmock
importlib-resources
pytest
pytest-mypy
pytest-timeout
pytest-venv
packaging
toml: toml
pytoml: pytoml

It lacks Pipenv support, but there is some tox-pipenv-install package on PyPI (I have never used it).

BTW we could also consider nox where the installation process with Pipenv might be easier.

@fridex
Copy link
Collaborator

fridex commented Jul 23, 2020

... and some tests require different packages installed to check behavior based on that - see toml/pytoml for RHEL compatibility testing.

@fridex
Copy link
Collaborator

fridex commented Aug 5, 2020

With #117 Thoth integration can be enabled. Hence only Thoth CI will need to be adjusted to have all the checks green.

@sesheta
Copy link
Member

sesheta commented Apr 17, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2021
@goern
Copy link
Member

goern commented Apr 19, 2021

/close

feel free to reopen

@sesheta
Copy link
Member

sesheta commented Apr 19, 2021

@goern: Closing this issue.

In response to this:

/close

feel free to reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants