-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI clean up #101
Comments
Thoth: Advise (Developer Preview) is a GitHub application that is generally/for all repos enabled in this org, the same for Prow/Tide. I can have a look at disabling both for this repo only. aicoe-ci (or thoth-ci) should be able to run tox/pytest @harshad16 |
/assign goern |
I am okay having them here because I know that only jobs I have to check are Travis and Coala but the motivation for this issue is how it looks to a new contributor. |
BTW, why have we removed |
Pipfile/Pipfile.lock is not used in this repo, requirements are managed by tox: Lines 7 to 16 in 0e6e0fe
It lacks Pipenv support, but there is some tox-pipenv-install package on PyPI (I have never used it). BTW we could also consider nox where the installation process with Pipenv might be easier. |
... and some tests require different packages installed to check behavior based on that - see toml/pytoml for RHEL compatibility testing. |
With #117 Thoth integration can be enabled. Hence only Thoth CI will need to be adjusted to have all the checks green. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/close feel free to reopen |
@goern: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Could we please decide which parts of micropipenv's CI to remove or fix? I mean, It's kinda misleading to contributors when a PR is merged even when a big portion of tests is red or unfinished.
I'd say that the codebase is tested on Travis but others might also implement some important checks and if they do, we should fix them.
The text was updated successfully, but these errors were encountered: