Add error message if composer install fails

Fixes issue botman#7
thormeier · Oct 2, 2017 · d2bdf58 · d2bdf58
1 parent f7cf5a6
commit d2bdf58
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -19,7 +19,8 @@
         "botman/botman": "~2.0",
         "illuminate/support": "~5.4.0|~5.5.0",
         "illuminate/console": "~5.4.0|~5.5.0",
-        "thecodingmachine/discovery": "^1.2"
+        "thecodingmachine/discovery": "^1.2",
+        "symfony/process": "^3.3"
     },
     "require-dev": {
         "phpunit/phpunit": "~5.0",

diff --git a/src/Composer.php b/src/Composer.php
@@ -18,6 +18,6 @@ public function install($package, callable $callback)
 
         $process->setCommandLine(trim($this->findComposer().' require '.$package));
 
-        $process->run($callback);
+        $process->mustRun($callback);
     }
 }
diff --git a/src/Console/Commands/BotManInstallDriver.php b/src/Console/Commands/BotManInstallDriver.php
@@ -5,6 +5,7 @@
 use GuzzleHttp\Client;
 use BotMan\Studio\Composer;
 use Illuminate\Console\Command;
+use Symfony\Component\Process\Exception\ProcessFailedException;
 
 class BotManInstallDriver extends Command
 {
@@ -75,9 +76,15 @@ public function handle()
 
         $this->info('Installing driver "'.$driver['name'].'"');
 
-        $this->composer->install('botman/driver-'.$installDriver, function ($type, $data) {
-            $this->info($data);
-        });
+        try {
+            $this->composer->install('botman/driver-'.$installDriver, function ($type, $data) {
+                $this->info($data);
+            });
+        } catch (ProcessFailedException $e) {
+            $this->error('Unable to install driver "'.$driver['name'].'":');
+            $this->error($e->getMessage());
+            exit(1);
+        }
 
         $this->info('Successfully installed driver "'.$driver['name'].'"');
     }