feat(Web): Added droplist for multi-package filtering #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhubert
commented
Jan 20, 2023
|
|
||
| const handleMobileDrawerToggle = () => { | ||
| setMobileDrawerOpen(!mobileDrawerOpen); | ||
| }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
Material UI v5 appears to have a proper SelectChangeEvent type for this, but Material v4 doesn't appear to, so had to turn off a couple of ESLint violations
|
Declining this PR in favor of #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93
I am not a react developer, so I'm hoping I did this correct. My local testing worked well. I'm not sure if we want to "pretty up" the package names with capitalization or anything, or change the placement of the droplist. Very open to suggestions.
This is a screenshot of the results of this on the log4brains code base:
When the different packages are selected, the ADRs that are displayed relate only to the selected package.