-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global): Updated default folder to decisions #98
Open
tylerhubert
wants to merge
1
commit into
thomvaill:develop
Choose a base branch
from
tylerhubert:docsDecisions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
docs/adr/20230119-use-the-term-decisions-instead-of-adr.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use the term decisions instead of adr | ||
|
||
- Status: accepted | ||
- Deciders: Tyler Hubert, Thomas Vaillant, Joel Parker Henderson | ||
|
||
Technical Story: https://github.com/thomvaill/log4brains/issues/12 | ||
|
||
## Context and Problem Statement | ||
|
||
The idea behind documenting any decision that gets made is becoming more popular. We should update the terminology in this library to reflect that any decision, not just architectural ones, should be documented and that this library can make that easier. | ||
|
||
## Decision Drivers | ||
|
||
- ADRs are starting to update their terminology to be Any Decision Records instead of Architectural, so using the more generic term decision is a simpler term that more people will understand. | ||
|
||
## Considered Options | ||
|
||
- Leave it as ADR | ||
- Change the default folder to docs/decisions | ||
|
||
## Decision Outcome | ||
|
||
Chose to update the default folder to docs/decisions along with adding an alias to the `log4brains adr new` to be `log4brains decision new`. This reflects the updated mindset that all decisions should be documented and not just architectural ones. | ||
|
||
### Positive Consequences | ||
|
||
- Hopefully more people will adopt this and document their decisions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we intend to switch back to "architectural" to strengthen the importance of "architecture". See our CHANGELOG of the upcoming release at https://github.com/adr/madr/blob/develop/CHANGELOG.md
Any feedback welcome!