-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more fields to search on #82
base: develop
Are you sure you want to change the base?
Conversation
Hi @my8bird, nice work! |
@@ -67,25 +67,33 @@ export class Search { | |||
adrs.map((adr) => [ | |||
adr.slug, | |||
{ | |||
title: adr.title || "Untitled", | |||
verbatim: adr.body.enhancedMdx // TODO: remove tags (https://github.com/thomvaill/log4brains/issues/5) | |||
title: adr.title || "Untitled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript type AdrForSearch
must be updated too.
You can run yarn typescript
to ensure your code is valid.
I found out that the typescript checks were indeed not run by the CI pipeline... This is now fixed. Could you please rebase on master
so the checks are executed?
As I said in comments, there is a typescript error to fix. |
Would you be open to someone taking this up and fixing the typings issue? Having tag search would be nice for bigger repos of ADRs. |
By all means sure. I was just getting a starting point in. I forgot about
this actually so thanks for keeping it moving.
…On Wed, Jan 18, 2023, 04:06 Steven Nance ***@***.***> wrote:
Would you be open to someone taking this up and fixing the typings issue?
Having tag search would be nice for bigger repos of ADRs.
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGJPFZ56ZGCS74RBGZNP3WS66BFANCNFSM55WZO5PQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Note: this skipped the lint-staged step because it airbnb's dependency has a main field set in the package json and the step wont pass
I updated to master and fixed the typescript errors. however, the lint-staged step would not pass for me due to a miss configured package json in the air bnb eslint dependency so I skipped that locally. |
Hi @thomvaill, Is there anything else left to do on this PR? |
No every thing was working locally. Might have been a bad version of that airbnb dep which was resolved. If it meets your standards and is a good idea I would love to get it merged in |
@thomvaill are you able to merge this? Tag search is the motivation for my question! Also thank you so much for an amazing tool! |
Adding tags, status, and deciders and searchable fields. Also, renamed verbatim to body so that in the search bar the user can easy search the body of the ADR.
These searches are now available powered by the luna package.