Skip to content

Commit

Permalink
chore: enforce typescript checks
Browse files Browse the repository at this point in the history
  • Loading branch information
thomvaill committed Sep 23, 2022
1 parent 371df79 commit f7fd0b0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ jobs:
run: yarn install --frozen-lockfile
# End of yarn setup

- name: typescript checks
run: yarn typescript

# We have to build all the packages before the tests
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ jobs:
# - steps.yarn-lock.outcome == 'success' --> yarn.lock was not changed
# - steps.yarn-lock.outcome == 'failure' --> yarn.lock was changed

- name: typescript checks
run: yarn typescript

# We have to build all the packages before the tests
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ When you are done, run `yarn unlink-cli && npm install -g log4brains` to use the
```bash
yarn lint # enforced automatically before every commit with husky+lint-staged
yarn format:fix # enforced automatically before every commit with husky+lint-staged
yarn typescript # enforced automatically before every commit with husky
yarn test:changed # (or `yarn test` to run all the tests)
```

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
},
"husky": {
"hooks": {
"pre-commit": "lint-staged",
"pre-commit": "lint-staged && yarn typescript",
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
}
},
Expand Down

0 comments on commit f7fd0b0

Please sign in to comment.