Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction.Populate & Cross-Platform Unification #209

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jul 25, 2024

PR-Codex overview

This PR enhances the Thirdweb SDK by adding a method to get nonce, improving gas fee handling, and refining transaction preparation and sending logic.

Detailed summary

  • Added ThirdwebGetNonce method to retrieve nonce asynchronously.
  • Improved gas fee handling in transactions.
  • Enhanced transaction preparation and sending logic for better performance.

The following files were skipped due to too many changes: Assets/Thirdweb/Core/Scripts/Transaction.cs, Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Test Results for iOS

  1 files  ±0   16 suites  ±0   7m 28s ⏱️ +4s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 280d3d0. ± Comparison against base commit a2e2960.

Copy link

Test Results for WebGL

  1 files  ±0   16 suites  ±0   7m 11s ⏱️ -10s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 280d3d0. ± Comparison against base commit a2e2960.

Copy link

Test Results for StandaloneLinux64

  1 files  ±0   16 suites  ±0   7m 35s ⏱️ -39s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 280d3d0. ± Comparison against base commit a2e2960.

Copy link

Test Results for Android

  1 files  ±0   16 suites  ±0   7m 31s ⏱️ +17s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 280d3d0. ± Comparison against base commit a2e2960.

@0xFirekeeper 0xFirekeeper merged commit d6173d9 into main Jul 25, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/populate-tx branch July 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant