Skip to content

[Update] Refactor claim condition retrieval and add support check (#4…

Codecov / codecov/project succeeded Sep 4, 2024 in 0s

59.98% (+0.03%) compared to 257e428

View this Pull Request on Codecov

59.98% (+0.03%) compared to 257e428

Details

Codecov Report

Attention: Patch coverage is 73.57143% with 74 lines in your changes missing coverage. Please review.

Project coverage is 59.98%. Comparing base (257e428) to head (f9c351c).

Files with missing lines Patch % Lines
...extensions/erc721/drops/read/getClaimConditions.ts 62.36% 35 Missing ⚠️
...sions/erc721/drops/read/getActiveClaimCondition.ts 59.37% 13 Missing ⚠️
...xtensions/erc721/drops/write/setClaimConditions.ts 70.00% 9 Missing ⚠️
...rdweb/src/extensions/erc721/drops/write/claimTo.ts 76.00% 6 Missing ⚠️
...s/thirdweb/src/extensions/erc721/write/lazyMint.ts 76.92% 6 Missing ⚠️
...nsions/erc721/drops/write/resetClaimEligibility.ts 92.85% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4391      +/-   ##
==========================================
+ Coverage   59.95%   59.98%   +0.03%     
==========================================
  Files         978      980       +2     
  Lines       79759    80024     +265     
  Branches     3630     3630              
==========================================
+ Hits        47818    48005     +187     
- Misses      31262    31340      +78     
  Partials      679      679              
Files with missing lines Coverage Δ
...web/src/utils/extensions/drops/get-claim-params.ts 100.00% <100.00%> (ø)
...nsions/erc721/drops/write/resetClaimEligibility.ts 92.85% <92.85%> (ø)
...rdweb/src/extensions/erc721/drops/write/claimTo.ts 91.66% <76.00%> (-8.34%) ⬇️
...s/thirdweb/src/extensions/erc721/write/lazyMint.ts 93.39% <76.92%> (-5.40%) ⬇️
...xtensions/erc721/drops/write/setClaimConditions.ts 89.41% <70.00%> (-10.59%) ⬇️
...sions/erc721/drops/read/getActiveClaimCondition.ts 69.76% <59.37%> (-6.90%) ⬇️
...extensions/erc721/drops/read/getClaimConditions.ts 62.36% <62.36%> (ø)

... and 3 files with indirect coverage changes