Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update wallet count from 350+ to 500+ and optimize SIWE linking #5818

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 20, 2024

Problem solved

Fixes TOOL-2792


PR-Codex overview

This PR primarily updates the documentation and user interface to reflect an increase in supported wallets from 350+ to 500+. It also improves the wallet connection logic to prevent unnecessary connections.

Detailed summary

  • Updated wallet count from 350+ to 500+ in various components and documentation.
  • Enhanced siwe.ts to only connect wallets if not already connected.
  • Modified placeholders and descriptions across multiple files to reflect the new wallet count.
  • Added a new ModalPreview component for better UI handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:11am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:11am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:11am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:11am

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: a9d1d11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Dec 20, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 20, 2024 01:01
@joaquim-verges joaquim-verges requested review from jakubkrehel and a team as code owners December 20, 2024 01:01
Copy link
Member Author

joaquim-verges commented Dec 20, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 2 s (-12.73% 🔽) 2.9 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 4.7 s (-30.6% 🔽) 6.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 381 ms (-10.5% 🔽) 492 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 130 ms (-18.29% 🔽) 140 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 703 ms (-7.03% 🔽) 1.1 s

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.34%. Comparing base (00af0ed) to head (a9d1d11).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5818   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 00af0ed
packages 50.56% <0.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx 49.01% <ø> (ø)
.../react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx 12.44% <ø> (ø)
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 39.50% <ø> (ø)
packages/thirdweb/src/wallets/create-wallet.ts 26.48% <ø> (ø)
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 5.57% <0.00%> (ø)

Copy link

linear bot commented Dec 20, 2024

@joaquim-verges joaquim-verges merged commit a89f766 into main Dec 20, 2024
32 of 36 checks passed
@joaquim-verges joaquim-verges deleted the feat_Update_wallet_count_from_350_to_500_and_optimize_SIWE_linking branch December 20, 2024 01:19
@jnsdls jnsdls mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant