Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-2809] Nebula - make the chat card a link in chat history page #5812

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the ChatHistoryPage component by improving the structure and interactivity of session titles and buttons.

Detailed summary

  • Changed the div class from overflow-hidden to relative overflow-hidden.
  • Wrapped the session title in a Link component for better navigation.
  • Added a className to the Link for positioning.
  • Updated the Button class to include relative z-10 for improved stacking context.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 19, 2024

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 20, 2024 11:24am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 20, 2024 11:24am
wallet-ui ⬜️ Skipped (Inspect) Dec 20, 2024 11:24am

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 22:04 Inactive
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: cfbe8c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:04 Inactive
@MananTank MananTank marked this pull request as ready for review December 19, 2024 22:04
@MananTank MananTank requested review from jakubkrehel and a team as code owners December 19, 2024 22:04
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 19, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (d14e0c4) to head (cfbe8c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5812   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4825     4825           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d14e0c4
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 604 ms (-16.02% 🔽) 1.6 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 2 s (+24% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 126 ms (+80.08% 🔺) 238 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 40 ms (+271.72% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 309 ms (+73.57% 🔺) 691 ms

Copy link

graphite-app bot commented Dec 20, 2024

Merge activity

…5812)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `ChatHistoryPage` component by improving the layout and interactivity of the session title and button elements.

### Detailed summary
- Changed the `div` class from `overflow-hidden` to `relative overflow-hidden`.
- Wrapped the session title in a `Link` component for better navigation.
- Added a `className` to the `Link` for styling.
- Modified the `Button` class to include `relative z-10` for improved stacking context.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-20-_tool-2809_nebula_-_make_the_chat_card_a_link_in_chat_history_page branch from b2e60f5 to cfbe8c3 Compare December 20, 2024 11:15
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 11:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 20, 2024 11:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 11:15 Inactive
@graphite-app graphite-app bot merged commit cfbe8c3 into main Dec 20, 2024
22 of 32 checks passed
@graphite-app graphite-app bot deleted the 12-20-_tool-2809_nebula_-_make_the_chat_card_a_link_in_chat_history_page branch December 20, 2024 11:24
@vercel vercel bot temporarily deployed to Production – docs-v2 December 20, 2024 11:24 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 20, 2024 11:24 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 20, 2024 11:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants