Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint documentation on portal #5810

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented Dec 19, 2024

Problem solved

Updated documentation for /chat and /execute

NEB-27


PR-Codex overview

This PR focuses on updating the transaction data structure and related messages for a blockchain transaction in the page.mdx file. It simplifies the transaction details by removing unnecessary fields and modifying the message format.

Detailed summary

  • Removed maxPriorityFeePerGas, maxFeePerGas, and gas from transaction data.
  • Updated the message field to clarify transaction details.
  • Changed session_id and request_id values for consistency.
  • Updated example responses to reflect the new transaction structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: samina <[email protected]>
@saminacodes saminacodes requested review from jakubkrehel and a team as code owners December 19, 2024 21:49
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 52aa5bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 10:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 10:32pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 19, 2024 10:32pm
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 10:32pm

Copy link

graphite-app bot commented Dec 19, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (8d17d05) to head (52aa5bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5810   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7674d13
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 852 ms (+11.05% 🔺) 1.8 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.7 s (-18.74% 🔽) 3.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 93 ms (+77.25% 🔺) 205 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 34 ms (-29.67% 🔽) 44 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 167 ms (+28.15% 🔺) 549 ms

Signed-off-by: samina <[email protected]>
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 22:26 Inactive
@eabdelmoneim eabdelmoneim self-requested a review December 19, 2024 22:27
@gregfromstl gregfromstl merged commit cfc1398 into main Dec 19, 2024
30 of 31 checks passed
@gregfromstl gregfromstl deleted the saminacodes-patch-1 branch December 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants