[TOOL-2807] Nebula: Fix incorrect prepared transaction object, Fix sign_transaction action not shown properly on page reload #5809
+57
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
force-pushed
the
12-20-_tool-2807_nebula_fix_incorrect_prepared_transaction_object_fix_sign_transaction_action_not_shown_properly_on_page_reload
branch
from
4fa3eb7 to
32f1bbf
Compare
MananTank
changed the base branch from
12-20-_tool-2800_insight_playground_combine_all_filter_query_params_in_a_group
to
main
MananTank
force-pushed
the
12-20-_tool-2807_nebula_fix_incorrect_prepared_transaction_object_fix_sign_transaction_action_not_shown_properly_on_page_reload
branch
from
32f1bbf to
74a1d99
Compare
jakeloo
approved these changes
Dec 19, 2024
jakeloo
approved these changes
Dec 19, 2024
size-limit report 📦
|
jakeloo
approved these changes
Dec 19, 2024
jakeloo
approved these changes
Dec 19, 2024
joaquim-verges
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5809 +/- ##
=======================================
Coverage 53.34% 53.34%
=======================================
Files 1101 1101
Lines 59124 59124
Branches 4825 4825
=======================================
Hits 31541 31541
Misses 26864 26864
Partials 719 719
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
…gn_transaction action not shown properly on page reload (#5809) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `Chat` component's handling of transaction messages, introducing a new transaction data structure, and modifying related components to support this change. ### Detailed summary - Updated `role` in `types.ts` to include `"action"`. - Replaced `SendTransactionOption` with `NebulaTxData` in `chat.ts`. - Refactored message handling in `ChatPageContent.tsx` to support transaction messages. - Created `NebulaTxData` type with properties for transaction details. - Adjusted `Chats.tsx` to utilize `NebulaTxData` in various functions. - Modified `SendTransactionButton` to prepare and send transactions using the new data structure. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-20-_tool-2807_nebula_fix_incorrect_prepared_transaction_object_fix_sign_transaction_action_not_shown_properly_on_page_reload
branch
from
74a1d99 to
b2a52d9
Compare
graphite-app
bot
deleted the
12-20-_tool-2807_nebula_fix_incorrect_prepared_transaction_object_fix_sign_transaction_action_not_shown_properly_on_page_reload
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR updates the handling of chat messages and transaction data in the
nebula-app. It introduces a new structure for transaction data and modifies how chat messages are processed, particularly focusing on the "action" role.Detailed summary
actionrole to thehistorytype intypes.ts.SendTransactionOptionwithNebulaTxDatainchat.ts.ChatPageContent.tsxto handleactionmessages.Chats.tsxto useNebulaTxDatafor transaction data.SendTransactionButton.