[SDK] Feature: Allow hiding the link profiles button #5799
Merged
+90
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90e2b97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5799 +/- ##
==========================================
+ Coverage 53.01% 53.20% +0.19%
==========================================
Files 1101 1101
Lines 59096 59095 -1
Branches 4813 4816 +3
==========================================
+ Hits 31329 31444 +115
+ Misses 27049 26934 -115
+ Partials 718 717 -1
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Dec 18, 2024
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a feature to hide the "Linked Profiles" button in the `ConnectButton` Details Modal based on the `allowLinkingProfiles` option. It also includes tests for the `ManageWalletScreen` to ensure the button's visibility behaves as expected.
### Detailed summary
- Added `manageWallet` option in `ConnectButtonProps` to configure wallet management.
- Updated `ManageWalletScreen` to conditionally render the linked profiles button based on `allowLinkingProfiles`.
- Created tests for `ManageWalletScreen` to verify button visibility based on `allowLinkingProfiles` settings.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
greg/tool-2718-ability-to-hide-the-link-a-profile-button
branch
from
7003766 to
90e2b97
Compare
graphite-app
bot
deleted the
greg/tool-2718-ability-to-hide-the-link-a-profile-button
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces the ability to hide the "Linked Profiles" button in the
ConnectButtonDetails Modal by adding a configuration option. It also updates theManageWalletScreento reflect this change and includes tests to ensure the functionality works as expected.Detailed summary
allowLinkingProfilesoption tomanageWalletinConnectButtonProps.ts.ManageWalletScreento conditionally render the linked profiles button based onallowLinkingProfiles.ManageWalletScreento verify button visibility based onallowLinkingProfiles.