Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-656] Update Dashboard Team layout #5798

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 18, 2024

Problem solved

CORE-656

  • Move the Team analytics from overview page to Analytics tab
  • Move the changelog to "projects" page and make that the default page to show on /team/

PR-Codex overview

This PR focuses on updating various links and references to the thirdweb dashboard, changing them to point to a more general team page instead of specific project pages. It also modifies the layout and content of several components related to team projects and analytics.

Detailed summary

  • Updated links in multiple .mdx files to point to https://thirdweb.com/team instead of project-specific URLs.
  • Changed the name and path in layout.tsx from Projects to Analytics.
  • Modified the TeamProjectsPage component to enhance the UI when no projects are found.
  • Removed unused analytics imports and functions in page.tsx.
  • Simplified the Changelog component structure and removed unnecessary functions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:11am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:11am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 0:11am
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 0:11am

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 22:34 Inactive
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 7711efe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 22:34 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Dec 18, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 18, 2024 22:35
@MananTank MananTank requested review from jakubkrehel and a team as code owners December 18, 2024 22:35
@MananTank MananTank changed the title CORE-[656] Update Dashboard Team layout [CORE-656] Update Dashboard Team layout Dec 18, 2024
Copy link

linear bot commented Dec 18, 2024

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (a2a61df) to head (7711efe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5798   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59096    59096           
  Branches     4813     4813           
=======================================
  Hits        31329    31329           
  Misses      27049    27049           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a2a61df
packages 50.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 366 ms (+62.75% 🔺) 1.3 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 582 ms (+18.65% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 75 ms (+402.34% 🔺) 187 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 58 ms (+1813.34% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 71 ms (+33.06% 🔺) 453 ms

Copy link

graphite-app bot commented Dec 18, 2024

Merge activity

joaquim-verges pushed a commit that referenced this pull request Dec 18, 2024
## Problem solved

CORE-656

* Move the Team analytics from overview page to Analytics tab
* Move the changelog to "projects" page and make that the default page to show on /team/<team-slug>

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating links and references related to the `thirdweb dashboard`, specifically changing URLs from `/~/projects` to `/` and modifying related text for clarity. It also refines components and functionality in the dashboard.

### Detailed summary
- Updated dashboard links from `/team/~/~/projects` to `/team`.
- Changed text references to reflect the new dashboard URL.
- Modified the `TeamProjectsPage` layout for improved user experience.
- Removed unused imports and functions in `page.tsx`.
- Added new analytics functionality in `analytics/page.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the 12-19-core-_656_update_dashboard_team_layout branch from 5503801 to e84cfc0 Compare December 18, 2024 23:47
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 23:47 Inactive
## Problem solved

CORE-656

* Move the Team analytics from overview page to Analytics tab
* Move the changelog to "projects" page and make that the default page to show on /team/<team-slug>

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating links related to the `thirdweb dashboard`, changing references from project-specific URLs to a more general team URL. Additionally, it refines the `TeamProjectsPage` component and enhances the analytics page structure.

### Detailed summary
- Updated links in multiple `.mdx` files to point to `https://thirdweb.com/team` instead of project-specific URLs.
- Modified `layout.tsx` to change the path from `projects` to `analytics`.
- Enhanced `TeamProjectsPage` to display a message when no projects are created, with a button to create a new project.
- Refactored the main page to include the `TeamProjectsPage` component and removed unnecessary analytics content.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the 12-19-core-_656_update_dashboard_team_layout branch from e84cfc0 to 7711efe Compare December 18, 2024 23:54
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 23:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 23:54 Inactive
@graphite-app graphite-app bot merged commit 7711efe into main Dec 19, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-19-core-_656_update_dashboard_team_layout branch December 19, 2024 00:12
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 00:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 00:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants