Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing async to connect docs #5789

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adds missing async to connect docs #5789

wants to merge 2 commits into from

Conversation

nischitpra
Copy link

@nischitpra nischitpra commented Dec 18, 2024

Problem solved

Adds missing async to connect callbacks in documentation


PR-Codex overview

This PR focuses on updating the connect function calls in multiple files to use an asynchronous arrow function instead of a regular function. This change enhances the handling of asynchronous operations within the connect function.

Detailed summary

  • Updated connect function calls in page.mdx files to use async () => instead of () =>.
  • Changes made in:
    • apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx
    • apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx
    • apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra requested review from jakubkrehel and a team as code owners December 18, 2024 02:04
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: b4996be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 2:56am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 2:56am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 2:56am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 2:56am

Copy link

graphite-app bot commented Dec 18, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (7d8566e) to head (b4996be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5789   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files        1101     1101           
  Lines       59080    59080           
  Branches     4810     4810           
=======================================
  Hits        31328    31328           
  Misses      27034    27034           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from db6920e
packages 50.16% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 3.2 s (+22.51% 🔺) 4.1 s
thirdweb (cjs) 110.85 KB (0%) 2.3 s (0%) 6.2 s (+6.69% 🔺) 8.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 388 ms (+102.12% 🔺) 500 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 176 ms (+67.47% 🔺) 186 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 1.3 s (+101.9% 🔺) 1.6 s

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 18, 2024
Copy link

graphite-app bot commented Dec 18, 2024

Merge activity

  • Dec 18, 2:47 AM UTC: @gregfromstl we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

  • Dec 18, 2:47 AM UTC: @gregfromstl we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

  • Dec 17, 9:51 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants