Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove hardcoded chain list from ConnectButton #5784

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR simplifies the ConnectButton component by removing unused chain imports and the associated chains array from the ThirdwebConnectButton.

Detailed summary

  • Removed import statements for unused chains: arbitrum, base, blast, defineChain, mainnet, optimism, and zkSync.
  • Deleted the chains prop from the ThirdwebConnectButton, which previously included multiple chains.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: f883c2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 17, 2024 10:09pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 22:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 17, 2024 22:07 Inactive
@github-actions github-actions bot added the Ecosystem Portal Involves changes to the Ecosystem Portal label Dec 17, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (9b3c7f6) to head (f883c2b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5784   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9b3c7f6
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 320 ms (+104.77% 🔺) 1.3 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 463 ms (-5.09% 🔽) 2.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 54 ms (+37.5% 🔺) 165 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 20 ms (+133.34% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 119 ms (+212.68% 🔺) 501 ms

@joaquim-verges joaquim-verges marked this pull request as ready for review December 17, 2024 22:14
@joaquim-verges joaquim-verges requested review from jakubkrehel and a team as code owners December 17, 2024 22:14
@joaquim-verges joaquim-verges merged commit 58bc4a9 into main Dec 17, 2024
32 of 35 checks passed
@joaquim-verges joaquim-verges deleted the fix_Remove_hardcoded_chain_list_from_ConnectButton branch December 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ecosystem Portal Involves changes to the Ecosystem Portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant