-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove hardcoded chain list from ConnectButton #5784
fix: Remove hardcoded chain list from ConnectButton #5784
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5784 +/- ##
=======================================
Coverage 52.99% 52.99%
=======================================
Files 1102 1102
Lines 59107 59107
Branches 4809 4809
=======================================
Hits 31323 31323
Misses 27066 27066
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR simplifies the
ConnectButton
component by removing unused chain imports and the associated chains array from theThirdwebConnectButton
.Detailed summary
arbitrum
,base
,blast
,defineChain
,mainnet
,optimism
, andzkSync
.chains
prop from theThirdwebConnectButton
, which previously included multiple chains.