Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Adds humanity testnet tx support #5783

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 17, 2024

PR-Codex overview

This PR focuses on adding support for the Humanity Testnet as a legacy transaction chain in the thirdweb package.

Detailed summary

  • Updated the .changeset/tricky-pears-check.md file to include a patch for thirdweb, noting the addition of Humanity Testnet.
  • In packages/thirdweb/src/gas/fee-data.ts, added 1942999413 as the identifier for Humanity Testnet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 17, 2024

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: e818f0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:12am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:12am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:12am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 0:12am

Copy link

graphite-app bot commented Dec 17, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (+0.02% 🔺) 899 ms (+0.02% 🔺) 155 ms (+13.9% 🔺) 1.1 s
thirdweb (cjs) 110.85 KB (+0.01% 🔺) 2.3 s (+0.01% 🔺) 374 ms (-6.29% 🔽) 2.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 22 ms (+12.81% 🔺) 134 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 5 ms (-30.9% 🔽) 15 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 35 ms (+1.45% 🔺) 416 ms

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (ecb4571) to head (e818f0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5783      +/-   ##
==========================================
+ Coverage   52.99%   53.02%   +0.03%     
==========================================
  Files        1102     1101       -1     
  Lines       59107    59080      -27     
  Branches     4809     4810       +1     
==========================================
+ Hits        31323    31328       +5     
+ Misses      27066    27034      -32     
  Partials      718      718              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ecb4571
packages 50.16% <100.00%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/gas/fee-data.ts 72.41% <100.00%> (+0.19%) ⬆️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 17, 2024
Copy link
Member

joaquim-verges commented Dec 17, 2024

Merge activity

  • Dec 17, 5:17 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 17, 6:59 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 17, 7:12 PM EST: A user merged this pull request with the Graphite merge queue.

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on adding support for the `Humanity Testnet` as a legacy transaction chain within the `thirdweb` package.

### Detailed summary
- Added `Humanity Testnet` with the value `1942999413` to the list of transaction chains in the `packages/thirdweb/src/gas/fee-data.ts` file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants