Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Chore: Update codeowners #5781

Merged
merged 1 commit into from
Dec 17, 2024
+7 −15
Merged

[ci] Chore: Update codeowners #5781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,26 +1,18 @@
# Order is important; the last matching pattern takes the most precedence.

# default ownership group
- @jnsdls @joaquim-verges @MananTank @gregfromstl
@thirdweb-dev/developer-tools
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default owner syntax appears incorrect. The line should be * @thirdweb-dev/developer-tools to properly match all files in the repository. The current hyphen prefix is not valid CODEOWNERS syntax and will not work as intended.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.


# packages
packages/thirdweb/ @joaquim-verges @gregfromstl @jnsdls
packages/thirdweb/ @thirdweb-dev/core-platform @thirdweb-dev/developer-tools

## specific thirdweb pieces
packages/thirdweb/src/react/ @joaquim-verges @gregfromstl @MananTank @jnsdls @edwardysun
packages/thirdweb/src/reactive/ @joaquim-verges @gregfromstl @MananTank @jnsdls
packages/thirdweb/src/gas/ @joaquim-verges @jnsdls
packages/thirdweb/src/pay/ @joaquim-verges @gregfromstl @MananTank @jnsdls @edwardysun
packages/service-utils/ @arcoraven @jnsdls @joaquim-verges
packages/eslint-config-thirdweb/ @jnsdls @joaquim-verges
packages/tw-tsconfig/ @jnsdls @joaquim-verges
packages/service-utils/ @thirdweb-dev/core-platform
packages/eslint-config-thirdweb/ @thirdweb-dev/core-platform @edwardysun
packages/tw-tsconfig/ @thirdweb-dev/core-platform @edwardysun

# apps
apps/ @jnsdls @joaquim-verges
apps/dashboard/ @jnsdls @MananTank @joaquim-verges @jakubkrehel
apps/playground-web/ @joaquim-verges @gregfromstl @jnsdls @joaquim-verges @jakubkrehel
apps/wallet-ui/ @gregfromstl @jnsdls @joaquim-verges @MananTank @jakubkrehel
apps/portal/ @thirdweb-dev/product @thirdweb-dev/platform @thirdweb-dev/infra
apps/ @thirdweb-dev/developer-tools @thirdweb-dev/core-platform @jakubkrehel

# .github folder + .changeset + turbo config is owned by jonas for now
scripts/ @jnsdls @joaquim-verges
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [opened, edited, ready_for_review]

env:
VALID_ISSUE_PREFIXES: "CNCT|DASH|PROT|INSIGHT|ENGINE|CS|DES|BIL|DEVX|SOLU|NEB"
VALID_ISSUE_PREFIXES: "CORE|TOOL"

jobs:
linear:
Expand Down
Loading