Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input type to API playground #5770

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineAfia
Copy link
Contributor

@AmineAfia AmineAfia commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR modifies the Input component in the blueprint-playground.client.tsx file to dynamically set the type attribute based on the param.type value.

Detailed summary

  • Added a conditional type attribute to the Input component:
    • Sets type to "text" if param.type is "string".
    • Sets type to "number" otherwise.
  • Updated the className for styling consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:51am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:51am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:51am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:51am

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 5b78cec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (bdb27e4) to head (5b78cec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5770   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bdb27e4
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 299 ms (+87.56% 🔺) 1.2 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 298 ms (+9.6% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 121 ms (+178.46% 🔺) 232 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (+223.13% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 51 ms (+51.29% 🔺) 433 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant