[DASH-638] Improve page load speed for <project>/connect tab by skipping a redirect #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
MananTank
requested review from
jnsdls,
joaquim-verges and
jakubkrehel
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5758 +/- ##
=======================================
Coverage 52.99% 52.99%
=======================================
Files 1102 1102
Lines 59107 59107
Branches 4809 4809
=======================================
Hits 31323 31323
Misses 27066 27066
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
MananTank
changed the title
size-limit report 📦
|
jnsdls
approved these changes
Dec 16, 2024
Comment on lines
+22
to
+24
| path: `${layoutPath}/connect/in-app-wallets`, | ||
| name: "Connect", | ||
| isActive: (path) => path.startsWith(`${layoutPath}/connect`), |
There was a problem hiding this comment.
means we have to keep this in mind if we ever want to prioritize another sub-tab
Merge activity
|
…ing a redirect (#5758) ## Problem solved DASH-638 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new `ProjectTabs` component to replace the existing `TabPathLinks` usage in the `TeamLayout`. It enhances tab management by allowing custom active tab logic and streamlining the tab structure. ### Detailed summary - Added `isActive` prop to the `links` array in `tabs.tsx`. - Introduced `ProjectTabs` component in `tabs.tsx` for managing project-related tabs. - Replaced `TabPathLinks` with `ProjectTabs` in `layout.tsx`. - Removed unused code for project fetching and not found handling in `page.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-17-improve_page_load_speed_for_project__connect_tab_by_skipping_a_redirect
branch
from
f86a86d to
b6deb15
Compare
graphite-app
bot
deleted the
12-17-improve_page_load_speed_for_project__connect_tab_by_skipping_a_redirect
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
DASH-638
PR-Codex overview
This PR introduces a new
ProjectTabscomponent, enhancing tab navigation within the project layout. It replaces the existingTabPathLinksimplementation, allowing for more dynamic tab activation based on the current path.Detailed summary
isActiveprop tolinksintabs.tsx.TabPathLinksusage with a newProjectTabscomponent.TabPathLinksimplementation inlayout.tsx.ProjectTabs.