Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH-635] Fix useActiveWalletChain not returning custom chain #5752

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a modification in the allChains.ts file to enhance the handling of custom chains by adding them to the allChainsV5 array after mapping them from version 4 to version 5.

Detailed summary

  • Added a comment to disable the ESLint rule for restricted syntax.
  • Pushed the mapped chain from mapV4ChainToV5Chain(c) into the allChainsV5 array.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 16, 2024

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 9:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 16, 2024 9:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 16, 2024 9:45pm
wallet-ui ⬜️ Skipped (Inspect) Dec 16, 2024 9:45pm

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: d85df8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 20:14 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 16, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 16, 2024 20:14
Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 3.1 s (+37.9% 🔺) 4 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 6.8 s (+23.03% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 385 ms (+115.01% 🔺) 496 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 57 ms (-17.42% 🔽) 67 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 706 ms (+20.93% 🔺) 1.1 s

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (2110792) to head (d85df8b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5752   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2110792
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link

graphite-app bot commented Dec 16, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds functionality to handle custom chains by mapping them to a new format and storing them in a separate array.

### Detailed summary
- Added a line to push mapped custom chains to the `allChainsV5` array using `mapV4ChainToV5Chain(c)`.
- Included an ESLint directive to disable the `no-restricted-syntax` rule for the new line.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-17-_dash-635_fix_useactivewalletchain_not_returning_custom_chain branch from 00ff86a to d85df8b Compare December 16, 2024 21:35
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 21:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 21:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 21:35 Inactive
@graphite-app graphite-app bot merged commit d85df8b into main Dec 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-635_fix_useactivewalletchain_not_returning_custom_chain branch December 16, 2024 21:51
@vercel vercel bot temporarily deployed to Production – wallet-ui December 16, 2024 21:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 16, 2024 21:51 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 16, 2024 21:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants