Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix: Nebula send transaction params #5744

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Dec 15, 2024

PR-Codex overview

This PR focuses on enhancing the SendTransactionButton component in the Chats.tsx file by integrating new transaction handling logic and ensuring compatibility with the dashboard's blockchain chain.

Detailed summary

  • Added sendTransaction import from thirdweb.
  • Introduced chain using useV5DashboardChain based on props.txData?.chainId.
  • Updated transaction validation to check for both props.txData and chain.
  • Modified transaction sending logic to use sendTransaction with additional parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Dec 15, 2024

Copy link

changeset-bot bot commented Dec 15, 2024

⚠️ No Changeset found

Latest commit: 0ddc123

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 11:41pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 15, 2024 11:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 15, 2024 11:41pm
wallet-ui ⬜️ Skipped (Inspect) Dec 15, 2024 11:41pm

Copy link

graphite-app bot commented Dec 15, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl added the hotfix This pull request should be prioritized in the merge queue. label Dec 15, 2024
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 15, 2024
Copy link
Member Author

gregfromstl commented Dec 15, 2024

Merge activity

  • Dec 15, 6:16 PM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 15, 6:37 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 15, 6:42 PM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl gregfromstl added merge-queue Adds the pull request to Graphite's merge queue. and removed Dashboard Involves changes to the Dashboard. labels Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (f91f631) to head (0ddc123).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5744   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files        1101     1101           
  Lines       59079    59079           
  Branches     4810     4810           
=======================================
  Hits        31327    31327           
  Misses      27034    27034           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f91f631
packages 50.16% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 496 ms (-5% 🔽) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.6 s (+35.98% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 93 ms (-22.43% 🔽) 205 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+65.2% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 225 ms (+36.05% 🔺) 605 ms

<!-- start pr-codex -->

## PR-Codex overview
This PR enhances the `SendTransactionButton` component in `Chats.tsx` by introducing improved transaction handling and validation through the addition of a blockchain `chain` context and the `sendTransaction` method.

### Detailed summary
- Added import for `sendTransaction` from `thirdweb`.
- Introduced `chain` variable using `useV5DashboardChain`.
- Updated transaction validation to check for both `txData` and `chain`.
- Refactored transaction sending logic to use `sendTransaction` with detailed parameters.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/cnct-2689-dashboard-fix-nebula-transaction-button-parameters branch from 2d4db18 to 0ddc123 Compare December 15, 2024 23:38
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 15, 2024 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 15, 2024 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 15, 2024 23:38 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 15, 2024
@graphite-app graphite-app bot merged commit 0ddc123 into main Dec 15, 2024
31 checks passed
@graphite-app graphite-app bot deleted the greg/cnct-2689-dashboard-fix-nebula-transaction-button-parameters branch December 15, 2024 23:42
@vercel vercel bot temporarily deployed to Production – docs-v2 December 15, 2024 23:42 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 15, 2024 23:42 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 15, 2024 23:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants