-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Fix: Nebula send transaction params #5744
[Dashboard] Fix: Nebula send transaction params #5744
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5744 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 1101 1101
Lines 59079 59079
Branches 4810 4810
=======================================
Hits 31327 31327
Misses 27034 27034
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
<!-- start pr-codex --> ## PR-Codex overview This PR enhances the `SendTransactionButton` component in `Chats.tsx` by introducing improved transaction handling and validation through the addition of a blockchain `chain` context and the `sendTransaction` method. ### Detailed summary - Added import for `sendTransaction` from `thirdweb`. - Introduced `chain` variable using `useV5DashboardChain`. - Updated transaction validation to check for both `txData` and `chain`. - Refactored transaction sending logic to use `sendTransaction` with detailed parameters. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
2d4db18
to
0ddc123
Compare
PR-Codex overview
This PR focuses on enhancing the
SendTransactionButton
component in theChats.tsx
file by integrating new transaction handling logic and ensuring compatibility with the dashboard's blockchain chain.Detailed summary
sendTransaction
import fromthirdweb
.chain
usinguseV5DashboardChain
based onprops.txData?.chainId
.props.txData
andchain
.sendTransaction
with additional parameters.