[SDK] useAutoConnect to throw error #5742
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
joaquim-verges,
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| setConnectionStatus("disconnected"); | ||
| if (e instanceof Error) { | ||
| console.warn("Error auto connecting wallet:", e.message); | ||
| throw e; |
There was a problem hiding this comment.
The state update to setConnectionStatus may be interrupted by the subsequent throw. Consider either:
- Removing
throw eto allow the state to update properly, or - Wrapping the state update in a
setTimeoutto ensure it completes before the error propagates
The choice depends on whether error propagation or state consistency is more important for this use case.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
def don't want to throw here. autoconnecting can fail for legit reasons (auth token expired, extension locked, etc)
what would be acceptable is to let the user pass an onError callback or return the error like any other mutation/query hook
size-limit report 📦
|
| setConnectionStatus("disconnected"); | ||
| if (e instanceof Error) { | ||
| console.warn("Error auto connecting wallet:", e.message); | ||
| throw e; |
There was a problem hiding this comment.
def don't want to throw here. autoconnecting can fail for legit reasons (auth token expired, extension locked, etc)
what would be acceptable is to let the user pass an onError callback or return the error like any other mutation/query hook
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving error handling in the
useAutoConnecthook by ensuring the connection status is set to "disconnected" when an error occurs during the wallet auto-connection process.Detailed summary
setConnectionStatus("disconnected");inside thecatchblock to handle errors.setConnectionStatus("disconnected");from the else block.