Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH-610] Fix useActiveWalletChain missing chain overrides added in dashboard #5731

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 13, 2024

Fixes: DASH-610


PR-Codex overview

This PR focuses on updating the handling of blockchain chain data in the connect-wallet component and related files. It introduces a new structure for managing chains, migrating from version 4 to version 5 chains and ensuring the connection manager is updated accordingly.

Detailed summary

  • Replaced allChains with allChainsV5 in CustomConnectWallet.
  • Added allChainsV5 to AllChainsStore type.
  • Initialized allChainsV5 in createAllChainsStore.
  • Updated store with allChainsV5 in createAllChainsStore.
  • Introduced SyncChainDefinitionsToConnectionManager to update the connection manager with allChainsV5 on change.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 5:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 13, 2024 5:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 13, 2024 5:07pm
wallet-ui ⬜️ Skipped (Inspect) Dec 13, 2024 5:07pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 16:49 Inactive
Copy link

linear bot commented Dec 13, 2024

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 2db8582

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 13, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 13, 2024 16:49
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (498a26e) to head (2db8582).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5731   +/-   ##
=======================================
  Coverage   52.89%   52.89%           
=======================================
  Files        1099     1099           
  Lines       59010    59010           
  Branches     4791     4791           
=======================================
  Hits        31211    31211           
  Misses      27083    27083           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 498a26e
packages 49.99% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 424 ms (+73.23% 🔺) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 680 ms (+6.66% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 95 ms (+410.49% 🔺) 207 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 58 ms (+1343.52% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 125 ms (+186.96% 🔺) 505 ms

Copy link

graphite-app bot commented Dec 13, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-13-_dash-610_fix_useactivewalletchain_missing_chain_overrides_added_in_dashboard branch from 314f79f to 2db8582 Compare December 13, 2024 16:59
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 16:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 16:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 16:59 Inactive
@graphite-app graphite-app bot merged commit 2db8582 into main Dec 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-13-_dash-610_fix_useactivewalletchain_missing_chain_overrides_added_in_dashboard branch December 13, 2024 17:08
@vercel vercel bot temporarily deployed to Production – docs-v2 December 13, 2024 17:08 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 13, 2024 17:08 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 13, 2024 17:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants