allow passing null to service scope, do not check domains on secretKey auth
#5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a077023 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jnsdls
force-pushed
the
12-12-allow_passing_null_to_service_scope_do_not_check_domains_on_secretkey_auth
branch
from
cfb4506 to
3c8ddee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5728 +/- ##
=======================================
Coverage 52.85% 52.85%
=======================================
Files 1098 1098
Lines 58976 58976
Branches 4788 4788
=======================================
Hits 31173 31173
Misses 27087 27087
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
jnsdls
force-pushed
the
12-12-allow_passing_null_to_service_scope_do_not_check_domains_on_secretkey_auth
branch
from
3c8ddee to
222f371
Compare
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 13, 2024
gregfromstl
approved these changes
Dec 13, 2024
Merge activity
|
…tKey` auth (#5728) fixes: DASH-621 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the authorization process by introducing an `authMethod` property and allowing `null` service scopes, while modifying billing statuses and service configuration types. ### Detailed summary - Added `authMethod` to `teamAndProjectResponse`. - Allowed passing `null` to `serviceScope` in `CoreServiceConfig`. - Changed `billingStatus` from `"noCustomer"` to `"noPayment"`. - Updated `TeamAndProjectResponse` to include `authMethod` type. - Adjusted authorization logic for `secretKey` and null service scopes. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-12-allow_passing_null_to_service_scope_do_not_check_domains_on_secretkey_auth
branch
from
222f371 to
a077023
Compare
arcoraven
reviewed
Dec 13, 2024
| @@ -42,11 +45,11 @@ export type TeamResponse = { | |||
| name: string; | |||
| slug: string; | |||
| image: string | null; | |||
| billingPlan: string; | |||
| billingPlan: "free" | "starter" | "growth" | "pro"; | |||
There was a problem hiding this comment.
Confirming if you want pro or custom
graphite-app
bot
deleted the
12-12-allow_passing_null_to_service_scope_do_not_check_domains_on_secretkey_auth
branch
arcoraven
approved these changes
Dec 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: DASH-621
PR-Codex overview
This PR introduces enhancements to the authorization process by allowing an
authMethodto be passed, enabling flexibility in service scope validation, and updating billing status options. It also improves type definitions for better clarity on authorization methods.Detailed summary
authMethodto theteamAndProjectResponse.nullforserviceScopeinCoreServiceConfig.billingStatusoptions from"noCustomer"to"noPayment".authorizeServiceandclientfunctions to handleauthMethod.authMethodinTeamAndProjectResponsetype.