[Service Utils] Feature: Accept Request in authorizeNode
#5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
arcoraven,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 90a16da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5724 +/- ##
=======================================
Coverage 52.85% 52.85%
=======================================
Files 1098 1098
Lines 58976 58976
Branches 4788 4788
=======================================
Hits 31173 31173
Misses 27087 27087
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
jnsdls
approved these changes
Dec 13, 2024
gregfromstl
added
the
merge-queue
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `authorizeNode` function by improving type handling for request headers and refactoring how headers are accessed. It introduces a type guard for distinguishing between header types and updates the way headers are retrieved in various functions.
### Detailed summary
- Updated `req` type in `AuthInput` to allow `Request`.
- Added `isNodeHeaders` function to differentiate between `IncomingHttpHeaders` and `Headers`.
- Refactored `getHeader` function to use `isNodeHeaders` for retrieving headers.
- Modified `extractAuthorizationData` to use `getHeader` for constructing the URL.
- Updated `logHttpRequest` to use `getHeader` for SDK-related headers.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
greg/cnct-2667-service-utils-accept-node-request-in-authorizenode
branch
from
7ad7c7e to
90a16da
Compare
graphite-app
bot
deleted the
greg/cnct-2667-service-utils-accept-node-request-in-authorizenode
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the
authorizeNodefunction in theservice-utilspackage by improving type handling for request headers and refactoring header retrieval logic.Detailed summary
reqtype inAuthInputto allowRequest.isNodeHeaderstype guard to distinguish betweenIncomingHttpHeadersandHeaders.getHeaderfunction to utilizeisNodeHeaders.extractAuthorizationDatato usegetHeaderfor host retrieval.logHttpRequestto usegetHeaderfor various header fields.