add roleBytes utility for contract role usage #5685
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dirtycajunrice
requested review from
joaquim-verges,
gregfromstl and
jnsdls
as code owners
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/utils/encoding/helpers/role-bytes.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## graphite-base/5685 #5685 +/- ##
===================================================
Coverage 51.23% 51.24%
===================================================
Files 1092 1093 +1
Lines 57346 57350 +4
Branches 4677 4676 -1
===================================================
+ Hits 29383 29387 +4
Misses 27247 27247
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
changed the base branch from
12-10-fix_ignore_of_mimetime_set_in_mediarenderer
to
graphite-base/5685
| * @example | ||
| * const AdminRole = roleBytes("ADMIN_ROLE"); | ||
| */ | ||
| export const roleBytes = (role: string): `0x${string}` => { |
There was a problem hiding this comment.
need to export it publicly, you can do that by exporting it from /exports
likely under /exports/extensions/common.ts where the other role stuff is
| /** | ||
| * Generates a 256-bit hash of a given role string in bytes form using the keccak256 algorithm. | ||
| * | ||
| * @param {string} role - The role string to be converted into bytes and hashed. |
There was a problem hiding this comment.
how about a union type for this of 'known' role strings + | ({} & string) to allow for others:
type KnownRoles = "ADMIN_ROLE" | "MINTER_ROLE" ...
type Role = KnownRoles | ({} & string)
gregfromstl
added
the
DO NOT MERGE
Problem solved
CNCT-2631
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a new utility function
roleBytesthat generates a 256-bit hash for role strings using thekeccak256algorithm. Additionally, it adds a test suite for this function to ensure its correctness.Detailed summary
roleBytesfunction inrole-bytes.tsto hash role strings.roleBytesfunction returns a 256-bit hash formatted as0x${string}.role-bytes.test.tsto validate theroleBytesfunction.LISTER_ROLE.