[SDK] Fix: Disconnect smart wallet when signer is disconnected #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
joaquim-verges,
MananTank,
jnsdls and
edwardysun
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c48e0c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5617 +/- ##
==========================================
+ Coverage 48.16% 48.97% +0.80%
==========================================
Files 1089 1089
Lines 56875 56891 +16
Branches 4363 4440 +77
==========================================
+ Hits 27396 27861 +465
+ Misses 28779 28325 -454
- Partials 700 705 +5
*This pull request uses carry forward flags. Click here to find out more.
|
| addConnectedWallet(wallet); | ||
|
|
||
| if (wallet.id !== "smart") { |
There was a problem hiding this comment.
hmmm i think this check is important. you sure we can remove this? basically we never want to write 'smart' as the LAST_ACTIVE_EOA_ID
gregfromstl
force-pushed
the
greg/cnct-2535-useactiveaccount-should-be-undefined-when-disconnect-with-aa
branch
from
c2e1166 to
5aa0797
Compare
joaquim-verges
approved these changes
Dec 5, 2024
gregfromstl
force-pushed
the
greg/cnct-2535-useactiveaccount-should-be-undefined-when-disconnect-with-aa
branch
2 times, most recently
from
0a94055 to
14069cb
Compare
Merge activity
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
gregfromstl
added
the
merge-queue
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
gregfromstl
added
the
hotfix
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving error handling and connection management for smart wallets within the `thirdweb` package, enhancing user experience by ensuring proper disconnection and validation of address inputs.
### Detailed summary
- Added error handling in `AccountProvider` for missing addresses.
- Implemented disconnection logic for smart wallets in `handleSmartWalletConnection`.
- Updated tests to cover new error scenarios and connection handling.
- Refactored `DetailsModal` to manage modal state based on active accounts.
- Improved test coverage for `DetailsModal` and connection manager functionalities.
> The following files were skipped due to too many changes: `pnpm-lock.yaml`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2535-useactiveaccount-should-be-undefined-when-disconnect-with-aa
branch
from
0942bdb to
c48e0c9
Compare
graphite-app
bot
deleted the
greg/cnct-2535-useactiveaccount-should-be-undefined-when-disconnect-with-aa
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the
AccountProviderandDetailsModalcomponents in thethirdwebpackage, adding error handling and enhancing wallet connection management.Detailed summary
AccountProviderfor missing address.DetailsModalto useuseCallbackfor closing the modal.AccountProviderandDetailsModal.createConnectionManager.