Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /solutions/consumer-apps to framer rewrites #5266

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 1, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: ba85fa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 11:20pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 1, 2024 11:20pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 1, 2024 11:20pm
wallet-ui ⬜️ Skipped (Inspect) Nov 1, 2024 11:20pm

Copy link

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:11 Inactive
@jnsdls jnsdls marked this pull request as ready for review November 1, 2024 23:11
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 1, 2024
Copy link
Member Author

jnsdls commented Nov 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (1c6c1bf) to head (ba85fa7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5266   +/-   ##
=======================================
  Coverage   45.37%   45.37%           
=======================================
  Files        1067     1067           
  Lines       55446    55446           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29598    29598           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1c6c1bf
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3.6 s (-1.29% 🔽) 4.5 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 7.6 s (+8.67% 🔺) 9.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 430 ms (+40.44% 🔺) 527 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 43 ms (-15.66% 🔽) 53 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 888 ms (+67.34% 🔺) 1.3 s

@jnsdls jnsdls merged commit 7a9713e into main Nov 1, 2024
31 of 34 checks passed
@jnsdls jnsdls deleted the add_/solutions/consumer-apps_to_framer_rewrites branch November 1, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant