Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove Drawer from mintTo form #5263

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the NFTMintButton and NFTMintForm components to replace the Drawer component with a new Sheet component for a better user interface. It also introduces state management for opening and closing the Sheet.

Detailed summary

  • Replaced Drawer with Sheet in NFTMintButton.
  • Updated SheetContent styling.
  • Changed onOpen and onClose to useState for managing modal visibility.
  • Added setOpen prop to NFTMintForm to control the Sheet.
  • Updated form submission logic and error handling.
  • Improved user feedback with toast notifications.
  • Cleaned up unused imports and variables.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: 9d1f75d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 20:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 20:56 Inactive
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 2:05am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 2, 2024 2:05am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 2, 2024 2:05am
wallet-ui ⬜️ Skipped (Inspect) Nov 2, 2024 2:05am

Copy link

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 20:56 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (21d794c) to head (9d1f75d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5263   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1067     1067           
  Lines       55449    55449           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29601    29601           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 21d794c
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 189 ms (+2.41% 🔺) 1.1 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 532 ms (+70.26% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 13 ms (+83.91% 🔺) 110 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 66 ms (+822.88% 🔺) 76 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 52 ms (-13.83% 🔽) 392 ms

@kien-ngo kien-ngo force-pushed the kien/chakra-cleanup-batch-upload-drawer branch from 6fe0f24 to b031c36 Compare November 1, 2024 23:34
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-mintTo-form branch from 2f01ab1 to cf3c54b Compare November 1, 2024 23:34
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:34 Inactive
@kien-ngo kien-ngo force-pushed the kien/chakra-cleanup-batch-upload-drawer branch from b031c36 to bec6e9d Compare November 1, 2024 23:35
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-mintTo-form branch from cf3c54b to aa57271 Compare November 1, 2024 23:35
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:35 Inactive
@kien-ngo kien-ngo force-pushed the kien/chakra-cleanup-batch-upload-drawer branch from bec6e9d to 0e78d34 Compare November 2, 2024 01:08
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-mintTo-form branch from aa57271 to 43d2a7f Compare November 2, 2024 01:09
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:09 Inactive
@graphite-app graphite-app bot added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 2, 2024
Copy link

graphite-app bot commented Nov 2, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `NFTMintButton` and `NFTMintForm` components to replace the `Drawer` component from `@chakra-ui/react` with a `Sheet` component for improved UI consistency and functionality.

### Detailed summary
- Replaced `Drawer` with `Sheet` in `NFTMintButton`.
- Updated `SheetContent` class properties for better responsiveness.
- Changed `SheetTitle` to have `text-left` class.
- Added `setOpen` prop to `NFTMintForm` to control visibility.
- Enhanced error handling with `toast` notifications.
- Refined form structure and validation messages in `NFTMintForm`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the kien/chakra-cleanup-batch-upload-drawer branch from 0e78d34 to 21d794c Compare November 2, 2024 01:55
@gregfromstl gregfromstl force-pushed the kien/remove-drawer-mintTo-form branch from 43d2a7f to 9d1f75d Compare November 2, 2024 01:55
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:55 Inactive
Base automatically changed from kien/chakra-cleanup-batch-upload-drawer to main November 2, 2024 02:05
@graphite-app graphite-app bot merged commit 9d1f75d into main Nov 2, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the kien/remove-drawer-mintTo-form branch November 2, 2024 02:06
@vercel vercel bot temporarily deployed to Production – wallet-ui November 2, 2024 02:06 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 2, 2024 02:06 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 2, 2024 02:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants