Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for Mintable, Royalty, Claimable, Transferable, BatchMetadata and OpenEdition modules #5219

Merged
merged 74 commits into from
Nov 6, 2024

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Oct 29, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the functionality and UI of various components in the dashboard application, including forms, modules, and UI elements, while also introducing new dependencies and improving existing code structure.

Detailed summary

  • Updated ContractEditModulesPageClient to check for localhost chain.
  • Added gap-3 to FormControl class.
  • Introduced publisherAddress in useForm default values.
  • Refactored CustomConnectWallet for better prop handling.
  • Added helperText to FormFieldSetup.
  • Improved error message display spacing.
  • Updated DatePickerWithRange for consistent styling.
  • Changed TransactionError type to export.
  • Enhanced error handling with ErrorBoundary in ModuleCard.
  • Introduced new useAllModuleContractInfo hook for fetching module data.
  • Added PropertiesFormControl for managing NFT attributes.
  • Implemented various storybook components for UI consistency.
  • Integrated OpenEditionMetadata and Royalty modules with improved form handling.
  • Added loading states and notifications for asynchronous operations.
  • Introduced BatchMetadata and Claimable modules with enhanced functionality.

The following files were skipped due to too many changes: apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/BatchMetadata.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Transferable.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Mintable.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Royalty.tsx, apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 8c8edd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:54pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:54pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:54pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:54pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.76%. Comparing base (0ad80db) to head (ce5e6dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5219   +/-   ##
=======================================
  Coverage   45.75%   45.76%           
=======================================
  Files        1069     1069           
  Lines       55606    55606           
  Branches     4074     4073    -1     
=======================================
+ Hits        25444    25448    +4     
+ Misses      29473    29469    -4     
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2de303a
packages 40.91% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 452 ms (+54.55% 🔺) 1.4 s
thirdweb (cjs) 103.05 KB (0%) 2.1 s (0%) 668 ms (+0.41% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 23 ms (+17.29% 🔺) 119 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 50 ms (+376.07% 🔺) 60 ms
thirdweb/react (minimal + tree-shaking) 17.56 KB (0%) 352 ms (0%) 243 ms (+77.88% 🔺) 595 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 29, 2024 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 29, 2024 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 29, 2024 17:24 Inactive
@MananTank MananTank changed the title Mintable module Add Mintable and Transerable module UI Oct 29, 2024
@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 29, 2024
MananTank
MananTank previously approved these changes Oct 29, 2024
Copy link
Member

MananTank commented Oct 29, 2024

Merge activity

  • Oct 29, 1:36 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 29, 1:36 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 29, 1:37 PM EDT: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Nov 6, 5:45 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 6, 5:47 PM EST: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Nov 6, 5:51 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 6, 5:54 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 6, 5:54 PM EST: A user added this pull request to the Graphite merge queue.

@MananTank MananTank marked this pull request as draft October 29, 2024 17:36
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Oct 29, 2024
@MananTank MananTank changed the title Add Mintable and Transerable module UI Add Mintable and Transferable module UI Oct 29, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 22:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 22:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 22:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 6, 2024 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 6, 2024 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 6, 2024 22:40 Inactive
@MananTank MananTank changed the base branch from main to modules November 6, 2024 22:43
@MananTank MananTank changed the base branch from modules to main November 6, 2024 22:44
@MananTank MananTank changed the base branch from main to modules November 6, 2024 22:45
@MananTank MananTank changed the base branch from modules to main November 6, 2024 22:45
@iuwqyir iuwqyir changed the base branch from main to modules November 6, 2024 22:46
@MananTank MananTank changed the base branch from modules to main November 6, 2024 22:46
@MananTank MananTank changed the base branch from main to modules November 6, 2024 22:46
@MananTank MananTank marked this pull request as draft November 6, 2024 22:46
@graphite-app graphite-app bot changed the base branch from modules to main November 6, 2024 22:46
@MananTank MananTank changed the base branch from main to modules November 6, 2024 22:47
@MananTank MananTank changed the base branch from modules to main November 6, 2024 22:48
@MananTank MananTank changed the base branch from main to modules November 6, 2024 22:48
@MananTank MananTank changed the base branch from modules to main November 6, 2024 22:49
@MananTank MananTank marked this pull request as ready for review November 6, 2024 22:50
@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 6, 2024
@jnsdls jnsdls merged commit d831cbf into main Nov 6, 2024
44 checks passed
@jnsdls jnsdls deleted the mintable-module branch November 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants