use partition ids with lightweight delete #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
_partition_id
to DELETE query in ClickHouse connector to optimize data deletion operations.What changed?
Modified the
deleteBatch
function to include_partition_id
in the DELETE query's WHERE clause. The partition ID is now set to match the chain_id, which helps ClickHouse identify the specific partition for deletion.How to test?
Why make this change?
ClickHouse performs better when DELETE operations include partition information. By adding the
_partition_id
to the query, we enable ClickHouse to quickly identify and remove data from specific partitions instead of scanning the entire table, resulting in more efficient delete operations.