Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lightweight deletes #120

Merged
merged 1 commit into from
Dec 4, 2024
Merged

use lightweight deletes #120

merged 1 commit into from
Dec 4, 2024

Conversation

iuwqyir
Copy link
Collaborator

@iuwqyir iuwqyir commented Dec 3, 2024

TL;DR

Updated the DELETE query syntax in ClickHouse to use lightweight DELETE FROM instead of ALTER TABLE DELETE.

What changed?

Modified the query string in the deleteBatch function to use DELETE FROM syntax instead of ALTER TABLE DELETE when removing data from ClickHouse tables.

How to test?

  1. Execute delete operations on ClickHouse tables
  2. Verify that records are successfully deleted
  3. Check that the operation completes without any syntax errors

Why make this change?

The ALTER TABLE DELETE syntax is deprecated in newer versions of ClickHouse. Using DELETE FROM is the standard and recommended approach for delete operations, ensuring better compatibility and maintainability.

Copy link
Collaborator Author

iuwqyir commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir marked this pull request as ready for review December 3, 2024 20:34
Copy link
Collaborator Author

iuwqyir commented Dec 4, 2024

Merge activity

  • Dec 4, 4:15 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 4:15 AM EST: A user merged this pull request with Graphite.

@iuwqyir iuwqyir merged commit 7aeffe8 into main Dec 4, 2024
5 checks passed
@iuwqyir iuwqyir deleted the 12-03-use_lightweight_deletes branch December 4, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants