Skip unmerged blocks in reorg handler #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for handling duplicate blocks during chain reorganization detection.
What changed?
findReorgEndIndex
to skip blocks with the same block number during reorg detectionHow to test?
TestHandleReorgWithDuplicateBlocks
TestNothingIsDoneForCorrectBlocks
Why make this change?
When processing block headers, duplicate blocks with the same block number can appear if there are multiple committers running by mistake. Usually clickhouse will merge these duplicates in the background, but these duplicates should not trigger reorg handling, as they represent unmerged blocks rather than actual chain reorganizations. This change ensures more accurate reorg detection by properly handling these edge cases.