Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auth, a working POC on claim-to #817

Open
wants to merge 3 commits into
base: lite-beta
Choose a base branch
from
Open

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 12, 2024

PR-Codex overview

This PR introduces enhancements for transaction management and authentication in a wallet system, particularly focusing on a new lite mode and improvements in handling transaction credentials.

Detailed summary

  • Added WalletTypeUnion type for wallet types.
  • Updated error handling in send-transaction-queue.ts.
  • Modified routes to accommodate a new lite mode.
  • Introduced TransactionCredentials interface for managing transaction data.
  • Enhanced authentication checks and error messages.
  • Refactored transaction simulation functions to utilize new credential structure.
  • Improved handling of transaction credentials across various routes and utilities.

The following files were skipped due to too many changes: src/server/middleware/auth.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@@ -79,6 +80,7 @@ export async function erc721claimTo(fastify: FastifyInstance) {
"x-account-factory-address": accountFactoryAddress,
"x-account-salt": accountSalt,
} = request.headers as Static<typeof walletWithAAHeaderSchema>;
const credentials = await getTransactionCredentials(request);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the start of the /claim-to call @d4mr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant