fix all biome errors #815
Merged
fix all biome errors #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
dirtycajunrice
force-pushed
the
12-11-fix_all_biome_errors
branch
3 times, most recently
from
2ba9f41 to
2c294a9
Compare
dirtycajunrice
changed the base branch from
12-11-bump_yarn_to_berry
to
12-11-update_workflow_action_versions
dirtycajunrice
force-pushed
the
12-11-fix_all_biome_errors
branch
from
2c294a9 to
498a9b3
Compare
dirtycajunrice
changed the base branch from
12-11-update_workflow_action_versions
to
main
dirtycajunrice
force-pushed
the
12-11-fix_all_biome_errors
branch
2 times, most recently
from
589cf6f to
2c11dea
Compare
dirtycajunrice
force-pushed
the
12-11-fix_all_biome_errors
branch
from
2c11dea to
a9a2068
Compare
arcoraven
reviewed
Dec 12, 2024
| @@ -14,7 +14,7 @@ jobs: | |||
| matrix: | |||
| include: | |||
| - platform: linux/amd64 | |||
| runner: ubuntu-latest | |||
There was a problem hiding this comment.
I'm not sure the implication of this one. cc @d4mr
package.json
Outdated
Comment on lines
95
to
98
| "@thirdweb-dev/auth/**/axios": ">=1.7.8", | ||
| "@thirdweb-dev/auth/**/web3-utils": ">=4.2.1", | ||
| "ethers-gcp-kms-signer/**/protobufjs": ">=7.2.5", | ||
| "fastify/**/find-my-way": ">=8.2.2", |
There was a problem hiding this comment.
These are needed to pin versions that don't have reported vulnerabilities. synk test on this branch brings back these vulns if we remove this:
✗ Cross-site Request Forgery (CSRF) [High Severity][https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459] in [email protected]
✗ Regular Expression Denial of Service (ReDoS) [Medium Severity][https://security.snyk.io/vuln/SNYK-JS-AXIOS-6124857] in [email protected]
✗ Cross-site Scripting (XSS) [Medium Severity][https://security.snyk.io/vuln/SNYK-JS-AXIOS-6671926] in [email protected]
✗ Prototype Pollution [High Severity][https://security.snyk.io/vuln/SNYK-JS-WEB3UTILS-6229337] in [email protected]
There was a problem hiding this comment.
Some of these may be removable since I only see the first two deps in this vuln report list.
Comment on lines
119
to
121
| ( | ||
| await userOpRes.json() | ||
| ) as RpcResponse; |
There was a problem hiding this comment.
Did biome format this? This seems weird and lower redability.
There was a problem hiding this comment.
My biome corrects this back
|
Report too large to display inline |
arcoraven
approved these changes
Dec 12, 2024
nischitpra
pushed a commit
that referenced
this pull request
Dec 12, 2024
* bump yarn to berry * fix all biome errors * bring back pinned resolved deps, fix whitepsace --------- Co-authored-by: Phillip Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR focuses on updating error handling, type safety, and configuration settings across various files, as well as upgrading dependencies to newer versions.
Detailed summary
.github/workflowsto useubuntu-24.04.unknowntype instead ofany.assyntax.src/shared/lib/cache/swr.ts.viemversion^2.21.54.